Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for async functions to preprocessor option #272

Merged
merged 7 commits into from
Mar 31, 2020
Merged

feat: add support for async functions to preprocessor option #272

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
586b15a
feat: add support for async functions to preprocessor option
EslamHiko Mar 30, 2020
c6591c9
docs: add asyncfunction support in the readme file
EslamHiko Mar 31, 2020
f616cfe
docs: remove AsyncFunction type
EslamHiko Mar 31, 2020
0c4371b
docs: fix small spacing
EslamHiko Mar 31, 2020
4c1933e
docs: remove spacings
EslamHiko Mar 31, 2020
67956b7
docs: uncentralize the description
EslamHiko Mar 31, 2020
a3125b9
docs: wip
EslamHiko Mar 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 9 additions & 10 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,12 @@ module.exports = {

## Options

| Name | Type | Default | Description |
| :---------------------------------: | :-------------------------: | :------------------------------------------: | :----------------------------------------------: |
| **[`attributes`](#attributes)** | `{Boolean\|Object}` | `true` | Enables/Disables attributes handling |
| **[`preprocessor`](#preprocessor)** | `{Function\|AsyncFunction}` | `undefined` | Allows pre-processing of content before handling |
| **[`minimize`](#minimize)** | `{Boolean\|Object}` | `true` in production mode, otherwise `false` | Tell `html-loader` to minimize HTML |
| **[`esModule`](#esmodule)** | `{Boolean}` | `false` | Use ES modules syntax |
| Name | Type | Default | Description |
| :---------------------------------: | :-----------------: | :------------------------------------------: | :----------------------------------------------: |
| **[`attributes`](#attributes)** | `{Boolean\|Object}` | `true` | Enables/Disables attributes handling |
| **[`preprocessor`](#preprocessor)** | `{Function}` | `undefined` | Allows pre-processing of content before handling |
| **[`minimize`](#minimize)** | `{Boolean\|Object}` | `true` in production mode, otherwise `false` | Tell `html-loader` to minimize HTML |
| **[`esModule`](#esmodule)** | `{Boolean}` | `false` | Use ES modules syntax |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why it is changed, if not new?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I added : in the last of --- under the description table which made the lint centralize the description 😅


### `attributes`

Expand Down Expand Up @@ -336,7 +336,7 @@ module.exports = {

### `preprocessor`

Type: `Function|AsyncFunction`
Type: `Function`
Default: `undefined`

Allows pre-processing of content before handling.
Expand Down Expand Up @@ -391,9 +391,8 @@ module.exports = {
};
```

#### `AsyncFunction`

You can set the `preprocessor` option as an Asynchronous Function (`AsyncFunction`) instance.
You can also set the `preprocessor` option as an Asynchronous Function (`async Function`) instance.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as an asynchronous function instance.

For example :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid space after :


**webpack.config.js**

Expand Down