Skip to content
This repository has been archived by the owner on Jan 19, 2021. It is now read-only.

docs(README): fix default value (options.esModules) #68

Merged
merged 1 commit into from
Jul 14, 2017
Merged

Conversation

BuonOmo
Copy link
Contributor

@BuonOmo BuonOmo commented Jul 13, 2017

According to issue #33, this defaults to false.

According to issue #33, this defaults to `false`.
@jsf-clabot
Copy link

jsf-clabot commented Jul 13, 2017

CLA assistant check
All committers have signed the CLA.

@BuonOmo BuonOmo changed the title Fix README esModules default value docs(README): Fix esModules default value Jul 13, 2017
@codecov
Copy link

codecov bot commented Jul 13, 2017

Codecov Report

Merging #68 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #68   +/-   ##
======================================
  Coverage    92.3%   92.3%           
======================================
  Files           2       2           
  Lines          13      13           
  Branches        2       2           
======================================
  Hits           12      12           
  Misses          1       1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d01c8b4...1c80495. Read the comment docs.

Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BuonOmo thx

@michael-ciniawsky michael-ciniawsky changed the title docs(README): Fix esModules default value docs(README): fix default value (options.esModules) Jul 14, 2017
@michael-ciniawsky michael-ciniawsky added this to the 3.0.1 milestone Jul 14, 2017
@michael-ciniawsky michael-ciniawsky merged commit 6da749f into webpack-contrib:master Jul 14, 2017
@BuonOmo BuonOmo deleted the patch-1 branch July 14, 2017 19:27
@michael-ciniawsky michael-ciniawsky removed this from the 3.0.2 milestone Oct 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants