fix: handling error better

webpack-contrib · May 25, 2023 · d5ad7a9 · d5ad7a9
1 parent 21caa3e
commit d5ad7a9
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 10 deletions.
diff --git a/src/index.js b/src/index.js
@@ -12,7 +12,15 @@ import LessError from "./LessError";
 async function lessLoader(source) {
   const options = this.getOptions(schema);
   const callback = this.async();
-  const implementation = getLessImplementation(this, options.implementation);
+  let implementation;
+
+  try {
+    implementation = getLessImplementation(this, options.implementation);
+  } catch (error) {
+    callback(error);
+
+    return;
+  }
 
   if (!implementation) {
     callback(

diff --git a/src/utils.js b/src/utils.js
@@ -232,15 +232,8 @@ function getLessImplementation(loaderContext, implementation) {
   if (!implementation || typeof implementation === "string") {
     const lessImplPkg = implementation || "less";
 
-    try {
-      // eslint-disable-next-line import/no-dynamic-require, global-require
-      resolvedImplementation = require(lessImplPkg);
-    } catch (error) {
-      loaderContext.emitError(error);
-
-      // eslint-disable-next-line consistent-return
-      return;
-    }
+    // eslint-disable-next-line import/no-dynamic-require, global-require
+    resolvedImplementation = require(lessImplPkg);
   }
 
   // eslint-disable-next-line consistent-return