Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor - first resolve filename in less, then in webpack #340

Merged
merged 3 commits into from
Apr 21, 2020
Merged

Refactor - first resolve filename in less, then in webpack #340

merged 3 commits into from
Apr 21, 2020

Conversation

cap-Bernardito
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

First resolve filename in less, then in webpack
Drop loadModule

Breaking Changes

Yes

Additional Info

No

@codecov
Copy link

codecov bot commented Apr 21, 2020

Codecov Report

Merging #340 into master will decrease coverage by 1.76%.
The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #340      +/-   ##
==========================================
- Coverage   96.85%   95.08%   -1.77%     
==========================================
  Files           8        7       -1     
  Lines         127      122       -5     
  Branches       27       27              
==========================================
- Hits          123      116       -7     
- Misses          4        6       +2     
Impacted Files Coverage Δ
src/createWebpackLessPlugin.js 93.87% <89.47%> (-4.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82cb6a7...8028b9a. Read the comment docs.

@alexander-akait alexander-akait merged commit 443bd5a into webpack-contrib:master Apr 21, 2020
@cap-Bernardito cap-Bernardito deleted the refactor branch April 24, 2020 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants