fix: hmr in browser extension

webpack-contrib · Aug 4, 2021 · 3d09da1 · 3d09da1
1 parent 3c9293b
commit 3d09da1
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 2 deletions.
diff --git a/src/hmr/hotModuleReplacement.js b/src/hmr/hotModuleReplacement.js
@@ -199,7 +199,7 @@ function isUrlRequest(url) {
   // An URL is not an request if
 
   // It is not http or https
-  if (!/^https?:/i.test(url)) {
+  if (!/^[a-zA-Z][a-zA-Z\d+\-.]*:/.test(url)) {
     return false;
   }
 

diff --git a/test/HMR.test.js b/test/HMR.test.js
@@ -262,6 +262,33 @@ describe("HMR", () => {
     }, 100);
   });
 
+  it("should reloads with browser extension protocol", (done) => {
+    document.head.innerHTML =
+      '<link rel="stylesheet" href="/dist/main.css" /><link rel="stylesheet" href="chrome-extension://main.css" />';
+
+    const update = hotModuleReplacement("./src/style.css", {});
+
+    update();
+
+    setTimeout(() => {
+      expect(console.log.mock.calls[0][0]).toMatchSnapshot();
+
+      const links = Array.prototype.slice.call(
+        document.querySelectorAll("link")
+      );
+
+      expect(links[0].visited).toBe(true);
+      expect(document.head.innerHTML).toMatchSnapshot();
+
+      links[1].dispatchEvent(getLoadEvent());
+
+      expect(links[1].isLoaded).toBe(true);
+      expect(links[2].visited).toBeUndefined();
+
+      done();
+    }, 100);
+  });
+
   it("should reloads with non-file script in the end of page", (done) => {
     document.body.appendChild(document.createElement("script"));
 

diff --git a/test/__snapshots__/HMR.test.js.snap b/test/__snapshots__/HMR.test.js.snap
@@ -12,6 +12,10 @@ exports[`HMR should reloads with absolute remove url 1`] = `"[HMR] css reload %s
 
 exports[`HMR should reloads with absolute remove url 2`] = `"<link rel=\\"stylesheet\\" href=\\"/dist/main.css\\"><link rel=\\"stylesheet\\" href=\\"http://localhost/dist/main.css?1479427200000\\"><link rel=\\"stylesheet\\" href=\\"http://dev.com/dist/main.css\\">"`;
 
+exports[`HMR should reloads with browser extension protocol 1`] = `"[HMR] css reload %s"`;
+
+exports[`HMR should reloads with browser extension protocol 2`] = `"<link rel=\\"stylesheet\\" href=\\"/dist/main.css\\"><link rel=\\"stylesheet\\" href=\\"http://localhost/dist/main.css?1479427200000\\"><link rel=\\"stylesheet\\" href=\\"chrome-extension://main.css\\">"`;
+
 exports[`HMR should reloads with link without href 1`] = `"[HMR] css reload %s"`;
 
 exports[`HMR should reloads with link without href 2`] = `"<link rel=\\"stylesheet\\" href=\\"/dist/main.css\\"><link rel=\\"stylesheet\\" href=\\"http://localhost/dist/main.css?1479427200000\\"><link rel=\\"shortcut icon\\">"`;

diff --git a/test/cases/hmr/expected/main.js b/test/cases/hmr/expected/main.js
@@ -220,7 +220,7 @@ function isUrlRequest(url) {
   // An URL is not an request if
 
   // It is not http or https
-  if (!/^https?:/i.test(url)) {
+  if (!/^[a-zA-Z][a-zA-Z\d+\-.]*:/.test(url)) {
     return false;
   }