Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

normalize-url not working in IE11 #385

Closed
lstkz opened this issue Apr 25, 2019 · 8 comments · Fixed by #399
Closed

normalize-url not working in IE11 #385

lstkz opened this issue Apr 25, 2019 · 8 comments · Fixed by #399
Labels
priority: 3 (important) semver: patch severity: 3 (broken) type: bug

Comments

@lstkz
Copy link

lstkz commented Apr 25, 2019

This module depends on normalize-url, but it doesn't work for IE11 because it's not transpiled to ES5.
For example https://github.com/sindresorhus/normalize-url/blob/master/index.js#L5 this line contains an arrow function.
I can see that there is a similar package but for es5 https://www.npmjs.com/package/normalize-url-es5.
@alexander-akait
Copy link
Member

Please use issue template, also we use old version normalize-url that support ES5 (https://github.com/webpack-contrib/mini-css-extract-plugin/blob/master/package.json#L44)

@alexander-akait
Copy link
Member

Oh, you are right need decrease version to 1.9.1 (https://github.com/sindresorhus/normalize-url/blob/v1.9.1/index.js)

@alexander-akait
Copy link
Member

/cc @ScriptedAlchemy

@DimitrK
Copy link

DimitrK commented May 8, 2019

same here

@ease-space ease-space mentioned this issue May 20, 2019
Closed
@ease-space
Copy link

@evilebottnawi Having the same issue. When will it be resolved?

@ScriptedAlchemy
Copy link
Contributor

Will open PR tonight. Ive got users on both my plugins opening issues about it. Sorry for delay folks!

@alexander-akait
Copy link
Member

Also we need fix check place

@ScriptedAlchemy ScriptedAlchemy mentioned this issue May 23, 2019
Merged
6 tasks
@jcarty
Copy link

jcarty commented May 24, 2019

@ScriptedAlchemy @evilebottnawi when will this go live?

elliottsj added a commit to elliottsj/extract-css-chunks-webpack-plugin that referenced this issue May 28, 2019
@elliottsj
Downgrade normalize-url to version 1.9.1
f7c4cf2 
Fixes faceyspacey#174

Similar to the fix for mini-css-extract-plugin:

- webpack-contrib/mini-css-extract-plugin#385
- webpack-contrib/mini-css-extract-plugin#399
@elliottsj elliottsj mentioned this issue May 28, 2019
Merged
ScriptedAlchemy pushed a commit to faceyspacey/extract-css-chunks-webpack-plugin that referenced this issue May 29, 2019
@elliottsj @ScriptedAlchemy
fix: downgrade normalize-url to version 1.9.1 (#176)
da5de61 
Fixes #174

Similar to the fix for mini-css-extract-plugin:

- webpack-contrib/mini-css-extract-plugin#385
- webpack-contrib/mini-css-extract-plugin#399
@brandonburkett brandonburkett mentioned this issue Jun 17, 2019
Closed
@yj-ang yj-ang mentioned this issue Aug 19, 2019
Closed
@bpeab bpeab mentioned this issue Aug 22, 2019
Closed
@Billaye Billaye mentioned this issue Oct 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: 3 (important) semver: patch severity: 3 (broken) type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: downgrading normalize-url ScriptedAlchemy/mini-css-extract-plugin
6 participants
@jcarty @lstkz @DimitrK @alexander-akait @ease-space @ScriptedAlchemy