Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pass absolute module path to serializer registration #894

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

Zackere
Copy link
Contributor

@Zackere Zackere commented Jan 11, 2022

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

#892

Breaking Changes

Additional Info

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 11, 2022

CLA Signed

The committers are authorized under a signed CLA.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Zackere
Copy link
Contributor Author

Zackere commented Jan 11, 2022

Just fyi: I am unathorized to run workflows, because this is my first contribution, so I'd be obliged if you could help me with that @alexander-akait

@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #894 (728dbb8) into master (65af0bb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #894   +/-   ##
=======================================
  Coverage   91.32%   91.32%           
=======================================
  Files           6        6           
  Lines         795      795           
  Branches      216      216           
=======================================
  Hits          726      726           
  Misses         63       63           
  Partials        6        6           
Impacted Files Coverage Δ
src/index.js 96.15% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65af0bb...728dbb8. Read the comment docs.

@Zackere Zackere changed the title Pass absolute module path to serializer registration fix: Pass absolute module path to serializer registration Jan 11, 2022
@Zackere
Copy link
Contributor Author

Zackere commented Jan 11, 2022

@alexander-akait sorry to bother, but can I ask for the workflow to be run again? I think linter will be happy this time

@alexander-akait
Copy link
Member

alexander-akait commented Jan 11, 2022

@Zackere Don't worry, I will rewrite commit message before merge, I wait @sokra answer to ensure it is safe, I took a look personally and did not find any serious problems, but it would be great if other eyes would look at this

@Zackere
Copy link
Contributor Author

Zackere commented Jan 11, 2022

Oh, ok, sure, i think the only complaint is the casing. Thanks

@Zackere
Copy link
Contributor Author

Zackere commented Jan 12, 2022

@alexander-akait do you know any ETA estimates? I know @sokra is very busy, I'm not trying to rush anything, just to organize my work and to decide whether or not I fork the repo and host it myself with the patch applied xd

@alexander-akait
Copy link
Member

Hope we will merge it today/tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants