Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #187

Merged
merged 7 commits into from
Jun 25, 2018
Merged

Update README.md #187

merged 7 commits into from
Jun 25, 2018

Conversation

way2ex
Copy link
Contributor

@way2ex way2ex commented Jun 22, 2018

Update README.md to tell user they can specify a custom path in url, relative or absolute

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

To help user comprehend the guide.

Breaking Changes

Additional Info

Update README.md to tell user they can specify a custom path in `url`, relative or absolute
@jsf-clabot
Copy link

jsf-clabot commented Jun 22, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests for this feature to avoid regressions in future?

@way2ex
Copy link
Contributor Author

way2ex commented Jun 22, 2018

I have add a svg and update webpack.config.js, and the result is correct.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't modify original tests, please add new, thanks! Also can we use other path to test like /my/own/path/.

@way2ex
Copy link
Contributor Author

way2ex commented Jun 23, 2018

I have add a new test case named simple-publicpath. The result is correct. Thank you for you advice.

@alexander-akait alexander-akait merged commit 0b3a7b2 into webpack-contrib:master Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants