Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: filter ident (options.ident) #314

Merged
merged 1 commit into from
Nov 24, 2017
Merged

test: filter ident (options.ident) #314

merged 1 commit into from
Nov 24, 2017

Conversation

solcik
Copy link
Contributor

@solcik solcik commented Nov 24, 2017

Hello,

I was just trying to figure out for a long time now, why my postcss-config is not taken into account, when using postcss-loader with webpack.
I dug into the loader and found this: https://github.com/postcss/postcss-loader/blob/master/lib/index.js#L53-L65, that is why my setup is not working.
Variable length has in this case value of 1, therefore return at line L65 and not using the postcssrc.

{
  loader: 'postcss-loader',
  options: {
    sourceMap: true,
    ident: 'postcss',
    config: {
      path: paths.DIR.ROOT,
    },
  },
};

@michael-ciniawsky
Copy link
Member

Thx 👍 Fixed in #315, you only need the ident if you are using a {Function} || require() withinoptions (normally when using options.plugins instead of a postcss.config.js)

@michael-ciniawsky michael-ciniawsky merged commit f33131c into webpack-contrib:master Nov 24, 2017
@michael-ciniawsky michael-ciniawsky changed the title test: ident && config not working test: filter ident (options.ident) Nov 24, 2017
@michael-ciniawsky
Copy link
Member

Fixed && Released in v2.0.9 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants