Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat support remark 14 #49

Closed
wants to merge 5 commits into from
Closed

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Sep 7, 2021

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

allow to use remark v14

Breaking Changes

No

Additional Info

  • jest still run babel on test files, need investigate

@alexander-akait
Copy link
Member Author

/cc @SimenB maybe you know what the problem is? jest just freeze and throw Segmentation fault, here we just rewrite our tests on ECMA modules, source code in CommonJS and we use import() (dynamic import) in our source code, if I remove it jest works fine, I try to debug, but no luck

@SimenB
Copy link

SimenB commented Sep 9, 2021

It explodes when hitting the first import() so I assume this is nodejs/node#35889 (segfault trace matches, so seems likely). The linked v8 issue had a bunch of movement in August, so 🤞 something comes out of it

@alexander-akait
Copy link
Member Author

Okay, let's start investigate, because it is big blocker for updating deps for us

@SimenB
Copy link

SimenB commented Sep 9, 2021

It's a bug in v8, not much we can do in userland unfortunately

@alexander-akait
Copy link
Member Author

Apparently we will have to be left without auto tests and do manual testing, as if we are returning to the stone age, we just can't update our deps and we really need new versions, I'm surprised that the problem takes so long to solve, that is very bad, thanks for link

@alexander-akait alexander-akait deleted the feat-support-remark-14 branch October 22, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants