Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-sass ^3.0.0-alpha.0 is not stable #71

Closed
kebot opened this issue Mar 30, 2015 · 17 comments
Closed

node-sass ^3.0.0-alpha.0 is not stable #71

kebot opened this issue Mar 30, 2015 · 17 comments

Comments

@kebot
Copy link

kebot commented Mar 30, 2015

error message:
node: ../deps/uv/src/unix/core.c:171: uv__finish_close: Assertionhandle->flags & UV_CLOSING' failed.`

Then I tried to install an old version of node-sass by npm install node-sass, but come out this error message:

npm ERR! peerinvalid The package node-sass does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer sass-loader@1.0.0 wants node-sass@^3.0.0-alpha.0

Maybe you can change the version number of node-sass to *, so I can specify the required version of node-sass.

@jrunestone
Copy link

+1 on this - using 0.5.0 now references an invalid version of node-sass (pre) and upgrading to 1.0.0 gives me the assertion error above :(

@alexeygolev
Copy link

Same here... had to go all the way down to sass-loader@0.4.2 and node-sass@2.0.1 with all the dancing of installing node-sass under iojs-v1.2 renaming the darwin folder and then switching back to iojs-v1.4... no luck with iojs-v1.6

@jrunestone
Copy link

If I declare sass-loader@1.0.0 and node-sass@3.0.0-beta.4 as separate dependencies, and then run npm update node-sass i can run webpack and it builds okay MOST of the time.. But it seems the original assertion error is some form of race condition that sadly still occurs from time to time.

@jhnns jhnns mentioned this issue Mar 30, 2015
@jhnns
Copy link
Member

jhnns commented Mar 30, 2015

Mhmm damn ... we can't just decrement the node-sass dependency because sass-loader 1.0.0 builds on the new API introduced with 3.0.0.

Maybe I can publish a stable sass-loader version without the new features introduced with 1.0.0...

@ghost
Copy link

ghost commented Mar 30, 2015

Have the same issue. Fix it like alexeygolev described using sass-loader@0.4.2.
Hope this issue will be fixed as soon as possible.

@maspwr
Copy link
Contributor

maspwr commented Mar 30, 2015

A 0.5.1 might be appropriate. Would moving node-sass to peerDependencies and changing to the next closest version available in npm work?

I also filed sass/node-sass#820.

@am11
Copy link

am11 commented Mar 30, 2015

Or perhaps get the latest of pre-release with "node-sass": "^3.0.0-". See https://github.com/sindresorhus/grunt-sass/pull/200/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2 (targeting latest beta).

@jhnns, let me know if there is any confusion implementing v3-beta breaking changes. :)

@am11
Copy link

am11 commented Mar 30, 2015

@kebot, that specific error is mitigated in beta, and v3 final, but not guaranteed to vanish for good. I still see it intermittently. It also depend on the runtime and version. (runtime = node.js or io.js).

@jhnns
Copy link
Member

jhnns commented Mar 31, 2015

@am11 thx for the support! 3.0.0-beta.4 is working pretty reliable in our tests.

@jrunestone
Copy link

@jhnns Is this an issue with sass-loader or node-sass? I'm still getting errors with sass-loader 1.0.1 and node-sass 3.0.0-beta.4 approx 70% of the times.

@jhnns
Copy link
Member

jhnns commented Apr 1, 2015

It's in node-sass: sass/node-sass#713

@jhnns
Copy link
Member

jhnns commented Apr 3, 2015

I've managed to write a version of sass-loader that provides the same features while depending on node-sass 2.1.1. It's on a separate branch and can be installed via npm i sass-loader@0.6.x. Please note, that sass-loader 0.6.0 is listing node-sass as peerDependency as well.

@jrunestone
Copy link

@jhnns Hmmm I'm sorry I'm getting the exact same behavior unfortunately.. Is it enough to remove the node-sass from node_modules and reinstall? I'm getting 2.1.1 but the errors remain. I'm using node 0.12.0 btw.. Did anyone else try 0.6.0?

bensmithett pushed a commit to bensmithett/cssconfracer that referenced this issue Apr 8, 2015
@jhnns
Copy link
Member

jhnns commented Apr 10, 2015

Yeah, we've realized that too 😞. It's a problem inside the custom importer code.

@lo1tuma
Copy link

lo1tuma commented May 6, 2015

The stable version of node-sass 3.0.0 was released today.

@jhnns
Copy link
Member

jhnns commented May 11, 2015

Awesome!

@jhnns
Copy link
Member

jhnns commented Aug 6, 2015

With sass-loader 2.0.0, you should have no problems with it anymore.

@jhnns jhnns closed this as completed Aug 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants