Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove klona #1034

Closed

Conversation

harish-sethuraman
Copy link
Contributor

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Remove klona and use de structuring instead of it

@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Base: 94.10% // Head: 94.10% // No change to project coverage 👍

Coverage data is based on head (f66b70e) compared to base (e8fbc79).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1034   +/-   ##
=======================================
  Coverage   94.10%   94.10%           
=======================================
  Files           5        5           
  Lines         373      373           
  Branches      137      138    +1     
=======================================
  Hits          351      351           
  Misses         19       19           
  Partials        3        3           
Impacted Files Coverage Δ
src/utils.js 92.76% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@harish-sethuraman
Copy link
Contributor Author

harish-sethuraman commented Mar 31, 2022

@alexander-akait thoughts??

@harish-sethuraman
Copy link
Contributor Author

@alexander-akait remainder in case if you had missed this

@harish-sethuraman
Copy link
Contributor Author

@alexander-akait ?

@alexander-akait
Copy link
Member

Let's postpone it after major release

@harish-sethuraman
Copy link
Contributor Author

Bump

@harish-sethuraman
Copy link
Contributor Author

👀

1 similar comment
@harish-sethuraman
Copy link
Contributor Author

👀

@alexander-akait
Copy link
Member

Can we rebase?

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 8, 2022

CLA Missing ID CLA Not Signed

@harish-sethuraman
Copy link
Contributor Author

Bumping 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants