Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide error stacktrace on Sass errors #1069

Merged
merged 1 commit into from Jun 27, 2022

Conversation

alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Jun 27, 2022

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Stacktraces can bloat the output with information that is not needed for the user to fix a Sass related syntax error.

Closes #1068

Stacktraces can bloat the output with information that is not needed for the user to fix a Sass related syntax error.

Closes webpack-contrib#1068
@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #1069 (aeca4c0) into master (5f0658e) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1069   +/-   ##
=======================================
  Coverage   94.10%   94.10%           
=======================================
  Files           5        5           
  Lines         373      373           
  Branches      137      137           
=======================================
  Hits          351      351           
  Misses         19       19           
  Partials        3        3           
Impacted Files Coverage Δ
src/SassError.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f0658e...aeca4c0. Read the comment docs.

@alexander-akait alexander-akait merged commit 5e6a61b into webpack-contrib:master Jun 27, 2022
13 checks passed
@alexander-akait
Copy link
Member

alexander-akait commented Jun 27, 2022

Thank you

@alan-agius4 alan-agius4 deleted the error-stacks- branch Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants