fix: importing file directly from scoped npm package

[roman-vanesyan]

pr #447 introduce an issue with direct import from scoped npm packages, preventing sass-loader from formatting imported file correctly (see #447 (comment)). This pr indented to fix the issue.

[roman-vanesyan]

Friendly /cc @d3viant0ne, as it is hotfix for issue introduce in #447

[michael-ciniawsky]

@vanesyan Please double check :) LGTM

[joshwiens]

For reference, while Johannes is busy irl and i'm filling in, if you can't get me via github and it's time sensitive just ping me on Twitter ( same name ) which will ding my cell.

[netmikey]

@d3viant0ne It looks like 6.0.5 didn't make it to npm yet. As builds are still failing, could you please have a look? Thanks in advance! :-)

[avivshafir]

I just got version 6.0.5 installed which broke my build.
The node-sass module was upgraded from version 6.0.4 just now and i get this error:

Module build failed: ModuleBuildError: Module build failed:
@import '~@widgets/widgets-ui-core/styles/style';
File to import not found or unreadable

The widgets module is an internal scoped module.
Is this something you expected?
If it's a breaking change it should been released not as a patch version probably.

[michael-ciniawsky]

@avivshafir Can you please provide a bit more context, the fix here is a semver patch && node-sass is should normally be a peerDependency you as the user control the version. But I'm not 💯 sure I understood the node-sass part correctly 😛

[alexander-akait]

@michael-ciniawsky just typo, node-sass -> sass-loader. node-sass is now only 4.5.2 😄

[roman-vanesyan]

6.0.5 patch still is not landed on npm. Did you install it through referencing to direct GitHub release url?

[michael-ciniawsky]

We have npm access problems atm (no one reachable) 😅 , but maybe we need another fix anyways 😛

[avivshafir]

Sorry guys I had a mistake the sass-loader was upgraded from 6.0.3 to 6.0.4 and not 6.0.5

[michael-ciniawsky]

@avivshafir Does v6.0.5 pulled from master npm i -D webpack-contrib/sass-loader fix the issue for you, could/did you test it ? 🙃

[avivshafir]

@michael-ciniawsky I am just confirming that 6.0.4 breakes my build and 6.0.5 is working as expected!
Thanks.

[michael-ciniawsky]

@avivshafir Thx appreciated

[netmikey]

6.0.5 is out on npm and I can confirm that it fixes my build :) Thx guys!