Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README): add example install instructions for dependencies #517

Merged
merged 1 commit into from
Feb 28, 2018

Conversation

w3apps
Copy link
Contributor

@w3apps w3apps commented Dec 14, 2017

When running the examples in the code an error is thrown that style-loader and css-loader are missing.

When running the examples in the code an error is thrown that `style-loader` and `css-loader` are missing.
@jsf-clabot
Copy link

jsf-clabot commented Dec 14, 2017

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Dec 14, 2017

Codecov Report

Merging #517 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #517   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files           6        6           
  Lines         117      117           
=======================================
  Hits          114      114           
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88b56d5...cdb57f7. Read the comment docs.

@alexander-akait
Copy link
Member

@w3apps why? you can you other loader for css instead standard

@w3apps
Copy link
Contributor Author

w3apps commented Dec 14, 2017

I know you can use other loaders. However, my change is strictly where the example uses those specific loaders. See attached image.
I am just a normal user (without prior webpack experience) that was following the examples step by step, and doing so I got stuck for a while until I realised what the problem was.

screen shot 2017-12-14 at 11 26 04

Copy link
Member

@joshwiens joshwiens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the examples specifically require loaders, we should add them as devDependencies to simplify the DX

@michael-ciniawsky michael-ciniawsky changed the title Add install script for missing dependencies docs(README): add install instructions for dependencies Feb 28, 2018
Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@w3apps Thx

@michael-ciniawsky michael-ciniawsky added this to the 6.0.7 milestone Feb 28, 2018
@michael-ciniawsky michael-ciniawsky changed the title docs(README): add install instructions for dependencies docs(README): add example install instructions for dependencies Feb 28, 2018
@michael-ciniawsky michael-ciniawsky merged commit a38344d into webpack-contrib:master Feb 28, 2018
@michael-ciniawsky michael-ciniawsky removed this from the 7.1.1 milestone Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants