Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: rename dart-sass to sass #624

Merged
merged 1 commit into from
Oct 30, 2018
Merged

Conversation

alexander-akait
Copy link
Member

No description provided.

@alexander-akait
Copy link
Member Author

Dart sass have sass name in npm repository (https://github.com/sass/dart-sass/blob/master/package/package.json#L2)

@codecov
Copy link

codecov bot commented Oct 30, 2018

Codecov Report

Merging #624 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #624   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files           6        6           
  Lines         137      137           
=======================================
  Hits          134      134           
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7bf7c0...9f5b672. Read the comment docs.

@alexander-akait
Copy link
Member Author

Feel free to feedback

@alexander-akait alexander-akait merged commit 472d09a into master Oct 30, 2018
@alexander-akait alexander-akait deleted the evilebottnawi-patch-1 branch October 30, 2018 22:22
@suazithustra
Copy link

suazithustra commented Dec 22, 2018

My sass module isn't being resolved, i'm getting the Cannot find module 'node-sass' error.

Ver. 7.1.0

@alexander-akait
Copy link
Member Author

@suazithustra run npm i node-sass --save-dev or npm i sass --save-dev (dart-sass)

@suazithustra
Copy link

suazithustra commented Dec 22, 2018

I did yarn add -D sass. It's not being resolved. Is there something else I might be missing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants