refactor: webpack defaults (#375)

.circleci/config.yml

@@ -4,25 +4,32 @@ unit_tests: &unit_tests
     - restore_cache:
         key: dependency-cache-{{ checksum "package-lock.json" }}
     - run:
-        name: NPM Rebuild
-        command: npm install
+        name: Install Latest NPM.
+        # npm@3 is buggy
+        command: if [[ $(npm -v | cut -c -1) > 3 ]] ; then npm i -g npm@latest; else echo "Skip npm updating"; fi
     - run:
-        name: Run unit tests.
+        name: NPM Install.
+        command: npm ci || npm i
+    - run:
+        name: Run Test.
         command: npm run ci:test
 canary_tests: &canary_tests
   steps:
     - checkout
     - restore_cache:
         key: dependency-cache-{{ checksum "package-lock.json" }}
     - run:
-        name: NPM Rebuild
-        command: npm install
+        name: Install Latest NPM.
+        command: npm i -g npm@latest
+    - run:
+        name: NPM Install.
+        command: npm ci
     - run:
-        name: Install Webpack Canary
+        name: Install Webpack Canary.
         command: npm i --no-save webpack@next
     - run:
-        name: Run unit tests.
-        command: if [[ $(compver --name webpack --gte next --lt latest) < 1 ]] ; then printf "n00p Canary Suite"; else npm run ci:test ; fi
+        name: Run Test.
+        command: if [[ $(compver --name webpack --gte next --lt latest) < 1 ]] ; then printf "Next is older than Latest - Skipping Canary Suite"; else npm run ci:test || true; fi
 
 version: 2
 jobs:
@@ -34,91 +41,82 @@ jobs:
       - restore_cache:
           key: dependency-cache-{{ checksum "package-lock.json" }}
       - run:
-          name: Install Dependencies
-          command: npm install
+          name: Install Latest NPM.
+          command: npm i -g npm@latest
+      - run:
+          name: NPM Install.
+          command: npm ci
       - save_cache:
           key: dependency-cache-{{ checksum "package-lock.json" }}
           paths:
             - ./node_modules
-
-  node8-latest:
+  analysis:
     docker:
-      - image: webpackcontrib/circleci-node8:latest
+      - image: webpackcontrib/circleci-node-base:latest
     steps:
       - checkout
       - restore_cache:
           key: dependency-cache-{{ checksum "package-lock.json" }}
       - run:
-          name: NPM Rebuild
-          command: npm install
+          name: Install Latest NPM.
+          command: npm i -g npm@latest
       - run:
-          name: Run unit tests.
-          command: npm run ci:coverage
+          name: NPM Install.
+          command: npm ci
       - run:
-          name: Submit coverage data to codecov.
-          command: bash <(curl -s https://codecov.io/bash)
-          when: on_success
+          name: Run linting.
+          command: npm run lint
+      - run:
+          name: Run NPM Audit.
+          command: npm run security
+      - run:
+          name: Validate Commit Messages.
+          command: npm run ci:lint:commits
   node6-latest:
     docker:
       - image: webpackcontrib/circleci-node6:latest
     <<: *unit_tests
-  node9-latest:
-    docker:
-      - image: webpackcontrib/circleci-node9:latest
-    <<: *unit_tests
-  node8-canary:
+  node8-latest:
     docker:
       - image: webpackcontrib/circleci-node8:latest
-    <<: *canary_tests
-  analysis:
+    <<: *unit_tests
+  node10-latest:
     docker:
-      - image: webpackcontrib/circleci-node-base:latest
+      - image: webpackcontrib/circleci-node10:latest
     steps:
       - checkout
       - restore_cache:
           key: dependency-cache-{{ checksum "package-lock.json" }}
       - run:
-          name: NPM Rebuild
-          command: npm install
-      # - run:
-      #     name: Run linting.
-      #     command: npm run lint
-      # - run:
-      #    name: Run NSP Security Check.
-      #    command: npm run security
-      # - run:
-      #     name: Validate Commit Messages
-      #     command: npm run ci:lint:commits
-  publish:
-    docker:
-      - image: webpackcontrib/circleci-node-base:latest
-    steps:
-      - checkout
-      - restore_cache:
-          key: dependency-cache-{{ checksum "package-lock.json" }}
+          name: Install Latest NPM.
+          command: npm i -g npm@latest
       - run:
-          name: NPM Rebuild
-          command: npm install
-      # - run:
-      #     name: Validate Commit Messages
-      #     command: npm run release:validate
+          name: NPM Install.
+          command: npm ci
       - run:
-          name: Publish to NPM
-          command: printf "noop running conventional-github-releaser"
+          name: Run Test.
+          command: npm run ci:coverage
+      - run:
+          name: Submit coverage data to codecov.
+          command: bash <(curl -s https://codecov.io/bash)
+          when: on_success
+  node8-canary:
+    docker:
+      - image: webpackcontrib/circleci-node8:latest
+    <<: *canary_tests
 
-version: 2.0
 workflows:
   version: 2
-  validate-publish:
+  test:
     jobs:
       - dependency_cache
-      - node6-latest:
+      - analysis:
           requires:
             - dependency_cache
           filters:
             tags:
               only: /.*/
-      - analysis:
+      - node6-latest:
           requires:
             - dependency_cache
           filters:
@@ -131,7 +129,7 @@ workflows:
           filters:
             tags:
               only: /.*/
-      - node9-latest:
+      - node10-latest:
           requires:
             - analysis
             - node6-latest
@@ -144,13 +142,4 @@ workflows:
             - node6-latest
           filters:
             tags:
-              only: /.*/
-      - publish:
-          requires:
-            - node8-latest
-            - node8-canary
-            - node9-latest
-          filters:
-            branches:
-              only:
-                - master
+              only: /.*/

.editorconfig

@@ -0,0 +1,13 @@
+# editorconfig.org
+
+[*]
+charset = utf-8
+indent_style = space
+indent_size = 2
+end_of_line = lf
+insert_final_newline = true
+trim_trailing_whitespace = true
+
+[*.md]
+insert_final_newline = true
+trim_trailing_whitespace = false

.eslintrc.js

@@ -0,0 +1,12 @@
+module.exports = {
+  root: true,
+  plugins: ['prettier'],
+  env: {
+    node: true,
+    browser: true
+  },
+  extends: ['@webpack-contrib/eslint-config-webpack'],
+  rules: {
+    'prettier/prettier': ['error'],
+  },
+};

.gitattributes

@@ -1,2 +1,4 @@
 # Treats the lock file as binary & prevents conflict hell
-yarn.lock -diff
+yarn.lock -diff
+* text=auto
+package-lock.json -diff

.github/CODEOWNERS

@@ -0,0 +1,6 @@
+# These are the default owners for everything in
+# webpack-contrib
+@webpack-contrib/org-maintainers
+
+# Add repository specific users / groups
+# below here for libs that are not maintained by the org.

.github/CONTRIBUTING.md

@@ -0,0 +1,124 @@
+## Contributing in @webpack-contrib
+
+We'd always love contributions to further improve the webpack / webpack-contrib ecosystem! 
+Here are the guidelines we'd like you to follow:
+
+* [Questions and Problems](#question)
+* [Issues and Bugs](#issue)
+* [Feature Requests](#feature)
+* [Pull Request Submission Guidelines](#submit-pr)
+* [Commit Message Conventions](#commit)
+
+### <a name="question"></a> Got a Question or Problem?
+
+Please submit support requests and questions to StackOverflow using the tag [[webpack]](http://stackoverflow.com/tags/webpack). 
+StackOverflow is better suited for this kind of support though you may also inquire in [Webpack Gitter](https://gitter.im/webpack/webpack). 
+The issue tracker is for bug reports and feature discussions.
+
+### <a name="issue"></a> Found an Issue or Bug?
+
+Before you submit an issue, please search the issue tracker, maybe an issue for your problem already exists and the discussion might inform you of workarounds readily available.
+
+We want to fix all the issues as soon as possible, but before fixing a bug we need to reproduce and confirm it. In order to reproduce bugs, we ask that you to provide a minimal reproduction scenario (github repo or failing test case). Having a live, reproducible scenario gives us a wealth of important information without going back & forth to you with additional questions like:
+
+- version of Webpack used
+- version of the loader / plugin you are creating a bug report for
+- the use-case that fails
+
+A minimal reproduce scenario allows us to quickly confirm a bug (or point out config problems) as well as confirm that we are fixing the right problem.
+
+We will be insisting on a minimal reproduce scenario in order to save maintainers time and ultimately be able to fix more bugs. We understand that sometimes it might be hard to extract essentials bits of code from a larger code-base but we really need to isolate the problem before we can fix it.
+
+Unfortunately, we are not able to investigate / fix bugs without a minimal reproduction, so if we don't hear back from you we are going to close an issue that doesn't have enough info to be reproduced.
+
+### <a name="feature"></a> Feature Requests?
+
+You can *request* a new feature by creating an issue on Github. 
+
+If you would like to *implement* a new feature, please submit an issue with a proposal for your work `first`, to be sure that particular makes sense for the project.
+
+### <a name="submit-pr"></a> Pull Request Submission Guidelines
+
+Before you submit your Pull Request (PR) consider the following guidelines:
+
+- Search Github for an open or closed PR that relates to your submission. You don't want to duplicate effort.
+- Commit your changes using a descriptive commit message that follows our [commit message conventions](#commit). Adherence to these conventions is necessary because release notes are automatically generated from these messages.
+- Fill out our `Pull Request Template`. Your pull request will not be considered if it is ignored.
+- Please sign the `Contributor License Agreement (CLA)` when a pull request is opened. We cannot accept your pull request without this. Make sure you sign with the primary email address associated with your local / github account.
+
+### <a name="commit"></a> Webpack Contrib Commit Conventions
+
+Each commit message consists of a **header**, a **body** and a **footer**.  The header has a special
+format that includes a **type**, a **scope** and a **subject**:
+
+```
+<type>(<scope>): <subject>
+<BLANK LINE>
+<body>
+<BLANK LINE>
+<footer>
+```
+
+The **header** is mandatory and the **scope** of the header is optional.
+
+Any line of the commit message cannot be longer 100 characters! This allows the message to be easier
+to read on GitHub as well as in various git tools.
+
+The footer should contain a [closing reference to an issue](https://help.github.com/articles/closing-issues-via-commit-messages/) if any.
+
+Examples: 
+```
+docs(readme): update install instructions
+```
+```
+fix: refer to the `entrypoint` instead of the first `module`
+```
+
+#### Revert
+If the commit reverts a previous commit, it should begin with `revert: `, followed by the header of the reverted commit. 
+In the body it should say: `This reverts commit <hash>.`, where the hash is the SHA of the commit being reverted.
+
+#### Type
+Must be one of the following:
+
+* **build**: Changes that affect the build system or external dependencies (example scopes: babel, npm)
+* **chore**: Changes that fall outside of build / docs that do not effect source code (example scopes: package, defaults)
+* **ci**: Changes to our CI configuration files and scripts (example scopes: circleci, travis)
+* **docs**: Documentation only changes (example scopes: readme, changelog)
+* **feat**: A new feature
+* **fix**: A bug fix
+* **perf**: A code change that improves performance
+* **refactor**: A code change that neither fixes a bug nor adds a feature
+* **revert**: Used when reverting a committed change
+* **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons)
+* **test**: Addition of or updates to Jest tests
+
+#### Scope
+The scope is subjective & depends on the `type` see above. A good example would be a change to a particular class / module.
+
+#### Subject
+The subject contains a succinct description of the change:
+
+* use the imperative, present tense: "change" not "changed" nor "changes"
+* don't capitalize the first letter
+* no dot (.) at the end
+
+#### Body
+Just as in the **subject**, use the imperative, present tense: "change" not "changed" nor "changes".
+The body should include the motivation for the change and contrast this with previous behavior.
+
+#### Footer
+The footer should contain any information about **Breaking Changes** and is also the place to
+reference GitHub issues that this commit **Closes**.
+
+**Breaking Changes** should start with the word `BREAKING CHANGE:` with a space or two newlines. The rest of the commit message is then used for this.
+
+Example
+
+```
+BREAKING CHANGE: Updates to `Chunk.mapModules`. 
+
+This release is not backwards compatible with `Webpack 2.x` due to breaking changes in webpack/webpack#4764
+Migration: see webpack/webpack#5225
+
+```

.github/ISSUE_TEMPLATE.md

@@ -1,15 +1,16 @@
-<!-- Before creating an issue please make sure you are using the latest version of style-loader. -->
+<!--
+  👉🏽 Need support, advice, or help? Don't open an issue!
+  Head to StackOverflow or https://gitter.im/webpack/webpack.
 
-**Do you want to request a *feature* or report a *bug*?**
-<!-- Please ask questions on StackOverflow or the webpack Gitter (https://gitter.im/webpack/webpack). Questions will be closed. -->
+  Hey there!
 
-**What is the current behavior?**
+  You arrived at this template because you felt none of the other options
+  matched the kind of issue you'd like to report. Please use this opportunity to
+  tell us about your particular type of issue so we can try to accomodate
+  similar issues in the future.
 
-**If the current behavior is a bug, please provide the steps to reproduce.**
-<!-- A great way to do this is to provide your configuration via a GitHub gist. -->
-
-**What is the expected behavior?**
-
-**If this is a feature request, what is motivation or use case for changing the behavior?**
-
-**Please mention other relevant information such as your webpack version, Node.js version and Operating System.**
+  PLEASE do note, if you're using this to report an issue already covered by the
+  existing template types, your issue may be closed as invalid. Our issue
+  templates contain fields that help us help you, and without that important
+  info, we might as well be ice-skating uphill, carrying a wooly mammoth.
+-->