feat: enable tag type configuration (#316)

* feat: enable tag type configuration * feat: enable tag type configuration -- added tests
webpack-contrib · Apr 17, 2018 · 892cba5 · 892cba5
1 parent 2c3e6b5
commit 892cba5
Show file tree

Hide file tree

Showing 2 changed files with 48 additions and 2 deletions.
diff --git a/lib/addStyles.js b/lib/addStyles.js
@@ -201,7 +201,9 @@ function removeStyleElement (style) {
 function createStyleElement (options) {
 	var style = document.createElement("style");
 
-	options.attrs.type = "text/css";
+	if(options.attrs.type === undefined) {
+		options.attrs.type = "text/css";
+	}
 
 	addAttrs(style, options.attrs);
 	insertStyleElement(options, style);
@@ -212,7 +214,9 @@ function createStyleElement (options) {
 function createLinkElement (options) {
 	var link = document.createElement("link");
 
-	options.attrs.type = "text/css";
+	if(options.attrs.type === undefined) {
+		options.attrs.type = "text/css";
+	}
 	options.attrs.rel = "stylesheet";
 
 	addAttrs(link, options.attrs);

diff --git a/test/basic.test.js b/test/basic.test.js
@@ -220,6 +220,26 @@ describe("basic tests", function() {
     runCompilerTest(expected, done);
   }); // it attrs
 
+  it("type attribute", function(done) {
+    // Setup
+    styleLoaderOptions.attrs = {type: 'text/less'};
+
+    fs.writeFileSync(
+      rootDir + "main.js",
+      [
+        "var a = require('./style.css');"
+      ].join("\n")
+    );
+
+    // Run
+    let expected = [
+      existingStyle,
+      `<style type="${styleLoaderOptions.attrs.type}">${requiredCss}</style>`
+    ].join("\n");
+
+    runCompilerTest(expected, done);
+  }); // it type attribute
+
   it("url", function(done) {
     cssRule.use = [
       {
@@ -261,6 +281,28 @@ describe("basic tests", function() {
     runCompilerTest(expected, done);
   }); // it url with attrs
 
+  it("url with type attribute", function (done) {
+    cssRule.use = [
+      {
+        loader: "style-loader/url",
+        options: {
+          attrs: {
+            type: 'text/less'
+          }
+        }
+      },
+      "file-loader"
+    ];
+
+    // Run
+    let expected = [
+      existingStyle,
+      '<link rel="stylesheet" type="text/less" href="ec9d4f4f24028c3d51bf1e7728e632ff.css">'
+    ].join("\n");
+
+    runCompilerTest(expected, done);
+  }); // it url with type attribute
+
   it("useable", function(done) {
     cssRule.use = [
       {