Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: injection algorithm #456

Merged
merged 2 commits into from
Jan 17, 2020
Merged

fix: injection algorithm #456

merged 2 commits into from
Jan 17, 2020

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Jan 17, 2020

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

partial #450

Breaking Changes

No

Additional Info

Some cases still broken and need fix:

  • same @import in two difference modules collapsed in one, we should fix it in css-loader, maybe add 4th argument for all @import, it is allow to distinguish css modules import from @import
  • When you use HMR and insert new @import it can create invalid order (rare use case)

@codecov
Copy link

codecov bot commented Jan 17, 2020

Codecov Report

Merging #456 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #456      +/-   ##
==========================================
+ Coverage   98.95%   99.06%   +0.11%     
==========================================
  Files           4        4              
  Lines         192      215      +23     
  Branches       88       92       +4     
==========================================
+ Hits          190      213      +23     
  Misses          2        2
Impacted Files Coverage Δ
src/index.js 95.65% <ø> (ø) ⬆️
src/runtime/injectStylesIntoStyleTag.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de38c39...b5f124f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant