-
-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ID's to <style>
tags
#336
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
18aef56
feat: auto parse variables: name and version
alex-mm ef0a684
fix: auto parse variables: name and version
alex-mm f45987e
Merge branch 'master' of https://github.com/webpack-contrib/style-loader
alex-mm 08d4782
test: attrs test
alex-mm 6f74cdc
fix: remove package "find-package"
alex-mm 0b31101
fix: add utils
alex-mm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
var path = require("path"); | ||
|
||
var utils = { | ||
exists: function (fileSystem, filename) { | ||
var exists = false; | ||
try { | ||
exists = fileSystem.statSync(filename).isFile(); | ||
} catch (err) { | ||
if (err.code !== "ENOENT") throw err; | ||
} | ||
|
||
return exists; | ||
}, | ||
|
||
findPackage: function (fileSystem, start) { | ||
var file = path.join(start, "package.json"); | ||
if (utils.exists(fileSystem, file)) { | ||
return require(file); | ||
} | ||
|
||
var up = path.dirname(start); | ||
|
||
// Reached root | ||
if (up !== start) { | ||
return utils.findPackage(fileSystem, up); | ||
} | ||
return null; | ||
}, | ||
|
||
addAttrs: function (element, attrs) { | ||
Object.keys(attrs).forEach(function (key) { | ||
element.setAttribute(key, attrs[key]); | ||
}); | ||
}, | ||
}; | ||
|
||
module.exports = utils; | ||
|
||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
var assert = require("assert"); | ||
var fs = require("fs"); | ||
var path = require("path"); | ||
var jsdom = require('jsdom'); | ||
var utils = require("../lib/utils"); | ||
|
||
var exists = utils.exists; | ||
var findPackage = utils.findPackage; | ||
var addAttrs = utils.addAttrs; | ||
|
||
describe('Utils Test', () => { | ||
it("exist", function(done) { | ||
assert.equal(exists(fs, path.join(__dirname, 'basic.test.js')), true); | ||
done(); | ||
}); | ||
|
||
it('not exist', function(done) { | ||
assert.equal(exists(fs, path.join(__dirname, 'xx.js')), false); | ||
done(); | ||
}); | ||
|
||
it('findPackage', function(done) { | ||
assert.equal(findPackage(fs, __dirname).name, 'style-loader'); | ||
done(); | ||
}); | ||
|
||
it('findPackage null', function(done) { | ||
assert.equal(findPackage(fs, '/'), null); | ||
done(); | ||
}); | ||
|
||
it('addAttrs', function(done) { | ||
jsdom.env( | ||
'<p></p>', | ||
[], | ||
function (err, window) { | ||
var doc = window.document; | ||
var ele = doc.createElement('div'); | ||
var attrs = { | ||
id: 'div', | ||
width: '100px' | ||
}; | ||
addAttrs(ele, attrs); | ||
assert.equal(ele.id, 'div'); | ||
assert.equal(ele.getAttribute('width'), '100px'); | ||
window.close(); | ||
done(); | ||
} | ||
); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need use
loader-utils.interpolateName
(https://github.com/webpack/loader-utils#interpolatename).Also
find-package
doesn't works good with mono repos, please don't use this package.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
find-package
has been removed.