Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: setAttributes function moved in module #519

Merged
merged 2 commits into from
Jul 12, 2021

Conversation

cap-Bernardito
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

setAttributes function moved in module
test:manual fixed

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #519 (05d4645) into master (1556c0b) will decrease coverage by 1.44%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #519      +/-   ##
==========================================
- Coverage   96.85%   95.40%   -1.45%     
==========================================
  Files          11       14       +3     
  Lines         254      261       +7     
  Branches      121      124       +3     
==========================================
+ Hits          246      249       +3     
- Misses          8       12       +4     
Impacted Files Coverage Δ
src/index.js 100.00% <ø> (ø)
src/runtime/setAttributesWithAttributes.js 0.00% <0.00%> (ø)
src/runtime/setAttributesWithAttributesAndNonce.js 0.00% <0.00%> (ø)
src/runtime/setAttributesWithoutAttributes.js 0.00% <0.00%> (ø)
src/utils.js 92.66% <88.88%> (-0.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1556c0b...05d4645. Read the comment docs.

@alexander-akait alexander-akait merged commit 8a26186 into master Jul 12, 2021
@alexander-akait alexander-akait deleted the refactor-set-attributes-fn branch July 12, 2021 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants