Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: insert option processed path to module #521

Merged
merged 6 commits into from
Jul 12, 2021

Conversation

cap-Bernardito
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Fixes #518

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #521 (4ec713a) into master (21c80c8) will decrease coverage by 0.16%.
The diff coverage is 96.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #521      +/-   ##
==========================================
- Coverage   95.47%   95.30%   -0.17%     
==========================================
  Files          14       14              
  Lines         265      277      +12     
  Branches      126      133       +7     
==========================================
+ Hits          253      264      +11     
- Misses         12       13       +1     
Impacted Files Coverage Δ
src/utils.js 92.68% <94.73%> (+0.02%) ⬆️
src/index.js 100.00% <100.00%> (ø)
src/runtime/insertBySelector.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21c80c8...4ec713a. Read the comment docs.

@alexander-akait alexander-akait merged commit 56fc8f0 into master Jul 12, 2021
@alexander-akait alexander-akait deleted the feat-insert-as-modulepath branch July 12, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style-loader duplicates insert function
2 participants