Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No warning and error messages #50

Closed
ihorkrys opened this issue Dec 21, 2016 · 4 comments
Closed

No warning and error messages #50

ihorkrys opened this issue Dec 21, 2016 · 4 comments

Comments

@ihorkrys
Copy link
Contributor

Hello!

There are no informative messages in console about error.
For now I can see just
Error: Failed because of a stylelint error. at linterSuccess (...somePath/node_modules/stylelint-webpack-plugin/lib/run-compilation.js:28:14)
But in version 0.4.0 were detailed error messages
13:12 ✖ Unexpected whitespace before ";" declaration-block-semicolon-space-before
I think problem is in run-compilation.js:
In version 0.4.0:
if (!options.quiet) { console.log(chalk.yellow(options.formatter(lint.results))); }
But now this code is removed.

@ihorkrys ihorkrys changed the title No warning, and error messages No warning and error messages Dec 21, 2016
ihorkrys added a commit to ihorkrys/stylelint-webpack-plugin that referenced this issue Dec 21, 2016
ihorkrys added a commit to ihorkrys/stylelint-webpack-plugin that referenced this issue Dec 22, 2016
@JaKXz JaKXz closed this as completed in ffbab73 Dec 27, 2016
@samrap
Copy link

samrap commented Jan 6, 2017

Can this be tagged in an 0.4.3 bug fix release please?

@JaKXz
Copy link
Contributor

JaKXz commented Jan 8, 2017

@samrap I apologise for the delay - I should have released a patch version right away. I was hoping to get some new features into a v0.5 release, and one of two is done :)

If you're willing, you can use stylelint-webpack-plugin#master and open any issues you see with it. Otherwise you can use the v0.4.3 tag.

I'll be releasing a new version soon - just had an (non-code) emergency to deal with last night. Appreciate your patience.

@JaKXz
Copy link
Contributor

JaKXz commented Jan 8, 2017

+ stylelint-webpack-plugin@0.5.0 published!

@samrap
Copy link

samrap commented Jan 9, 2017

Awesome! Thanks for all your hard work, this plugin is great!

joshwiens pushed a commit that referenced this issue Mar 31, 2018
Fixes #50.

* No warning and error messages

* Add test for warning messaging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants