StyleLint plugin should work without configuration and just use default one #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaKXz
reviewed
Sep 21, 2016
There was a problem hiding this comment.
Thanks for the PR! TBH I think the good reason for requiring the config is to make sure your .stylelintrc file is picked up.
I suppose we could allow you to just pass in the path to your .stylelintrc as the only option and then just use the defaults for the rest. What do you think?
|
|
||
| return pack(assign({}, baseConfig, config)) | ||
| .then(function (stats) { | ||
| expect(stats.compilation.errors).to.have.length(0); |
There was a problem hiding this comment.
Could you add the assertion for the stats.compilation.warnings as well (since the test title implies it)?
|
I don't think we should requiring config, default one works great. Same as eslint |
|
@vieron I've had some time to think about this properly and I think it's a good idea. Do you have any objections? If not I'll release this as the next version :) |
joshwiens
pushed a commit
that referenced
this pull request
Mar 31, 2018
* It should work without configuration, just use default one * It should warn user if .stylelintrc file does not exit * Add warnings check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it throws exception for this config:
This is fix for this use case