Support loader prefixes when resolving paths

[kpdecker]

No description provided.

[PatrickJS]

+1

[mzgoddard]

I think we can do this. @kpdecker the resolver file seems out of date with the latest stylus 0.49.3 which we have as our peer dependency. If so can you update that file, put the stylus version at the top of the file with your comment and put in comments like // stylus-loader: BEGIN DIFFERENCE WITH SYTLUS and a similar one to end to signify the blocks of that file that are different.

Thanks!

[kpdecker]

@mzgoddard this deviates from the stylus file fairly dramatically, some from me refactoring, some from functional changes:
https://gist.github.com/kpdecker/7d9fbe212a11ec2efd9f

I think that trying to shoehorn into the pattern that they are following there will hurt the readability of the code vs. just calling it a divergent fork of this file.

[mzgoddard]

@kpdecker I think you have a really great point. This seems difficult to keep up to date with mainline stylus since its essentially a forked file. I've been thinking about how we can make this maintainable. I don't think I've thought of a great answer that lets us take immediate use of your work with little change. Any thoughts you may have on this would be great. If we can't think of anything I think I'll go ahead and merge after this week since this is definitely useful work.

Thanks for everything so far.

[kpdecker]

Not sure that I'm aware of anything and I'm without laptop on vacation, so
I'm not sure I can provide better feedback right now.

On Tue Feb 17 2015 at 2:31:22 PM mzgoddard notifications@github.com wrote:

@kpdecker https://github.com/kpdecker I think you have a really great
point. This seems difficult to keep up to date with mainline stylus since
its essentially a forked file. I've been thinking about how we can make
this maintainable. I don't think I've thought of a great answer that lets
us take immediate use of your work with little change. Any thoughts you may
have on this would be great. If we can't think of anything I think I'll go
ahead and merge after this week since this is definitely useful work.

Thanks for everything so far.

—
Reply to this email directly or view it on GitHub
#28 (comment).

[mzgoddard]

Merged as ab62a5f. Sorry for the delay.