Add cached sources to sourcemap #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 , this issue is pretty dire, it's rendering source map useless |
|
This PR still having problem with sourcemap of styl module requested outside root. eg: require "kouto-swiss" inside node module still return null sourcemap content |
|
Great! SourceMap works well now! |
|
The sourcemap won't update when the source changed |
|
@singggum3b Did you find a solution for sourcemap requested outside root? Experience an issue like #56. |
|
just use stylus directly then load the css with its source file instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only the main, top-level source is added to the sourcemap, resulting in empty maps for any included files. This PR adds the missing sources from the cache. Fixes #56