Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump and audit dependencies with npm audit fix #47

Merged
merged 10 commits into from
Dec 17, 2018

Conversation

mistic
Copy link
Collaborator

@mistic mistic commented Dec 14, 2018

Small PR to bump the used dependencies for newer version and run npm audit fix to ensure security standards.

jest and babel-jest are not bumped to the last version as they are not compatible with node 4.8 that we still support. Another PR to drop the support for node 4 is already opened #48

CC\ @evilebottnawi

…bpack to v4 on example. chore(NA): declare dependencies for example on its own package.json.
@mistic mistic mentioned this pull request Dec 14, 2018
@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #47 into master will increase coverage by 4.46%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
+ Coverage   12.67%   17.14%   +4.46%     
==========================================
  Files           7        7              
  Lines         355      350       -5     
  Branches       61       57       -4     
==========================================
+ Hits           45       60      +15     
+ Misses        272      259      -13     
+ Partials       38       31       -7
Impacted Files Coverage Δ
src/workerPools.js 0% <0%> (ø) ⬆️
src/worker.js 0% <0%> (ø) ⬆️
src/index.js 70% <0%> (+70%) ⬆️
src/cjs.js 100% <0%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c891a9c...d3ebc70. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, need rebase

@mistic
Copy link
Collaborator Author

mistic commented Dec 17, 2018

@evilebottnawi rebase applied

@alexander-akait alexander-akait merged commit 1f81d04 into webpack-contrib:master Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants