Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix thread-loader memory leaks and worker and main process lifecycles #51

Merged
merged 5 commits into from
Dec 19, 2018

Conversation

mistic
Copy link
Collaborator

@mistic mistic commented Dec 19, 2018

This PR is very important and should be merged and released as a patch as soon as possible.
It basically fixes a memory leak introduced by #42 and also fixes the lifecycle both for the worker and for the main process from thread-loader. With those changes we should be able to get away with every issue related with getting the thread-loader hanging or outputting broken pipe errors directly into the shell stdout after running.

The tests were also updated.

CC\ @evilebottnawi

@codecov
Copy link

codecov bot commented Dec 19, 2018

Codecov Report

Merging #51 into master will decrease coverage by 0.27%.
The diff coverage is 13.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
- Coverage   17.26%   16.98%   -0.28%     
==========================================
  Files           7        7              
  Lines         365      424      +59     
  Branches       60       71      +11     
==========================================
+ Hits           63       72       +9     
- Misses        268      309      +41     
- Partials       34       43       +9
Impacted Files Coverage Δ
src/readBuffer.js 37.5% <0%> (+4.16%) ⬆️
src/worker.js 0% <0%> (ø) ⬆️
src/WorkerPool.js 23.38% <31.57%> (+2.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9208e3b...8d90e09. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, will be great increase coverage to 80-90%, but we can do it in other PRs

@alexander-akait alexander-akait merged commit f10fe55 into webpack-contrib:master Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants