Skip to content
This repository has been archived by the owner on Dec 5, 2019. It is now read-only.

docs(README): mangle.props instead of mangle.properties #207

Merged
merged 1 commit into from Jan 9, 2018
Merged

Conversation

davilima6
Copy link
Contributor

No description provided.

CHANGELOG.md Outdated
@@ -8,6 +8,7 @@ All notable changes to this project will be documented in this file. See [standa

### Bug Fixes

* Fix typo: mangle properties key should be props
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this change as the CHANGELOG is generated and the PR isn't part of this particular release :)

Copy link
Contributor Author

@davilima6 davilima6 Jan 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the advice but I'm not sure this PR is not correct. It seems to have changed from 0.4.6 to 1.x and other places in the code do use properties as the new option.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CHANGELOG is still auto generated from commit messages and your PR isn't part of the v1.1.6 release, so this needs to be reverted please :)

Copy link
Contributor Author

@davilima6 davilima6 Jan 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. it'd be nice if that could be set to collect msgs only from master branch.

@michael-ciniawsky michael-ciniawsky changed the title Fix docs: mangle.props instead of mangle.properties docs(README): mangle.props instead of mangle.properties Jan 8, 2018
@michael-ciniawsky michael-ciniawsky added this to the 1.1.6 milestone Jan 8, 2018
Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kzc
Copy link

kzc commented Jan 29, 2018

@michael-ciniawsky This PR is incorrect. Please revert.

The uglify minify() mangle sub-option is properties, not props.

See: https://github.com/mishoo/UglifyJS2/tree/harmony#minify-options-structure

@michael-ciniawsky
Copy link
Member

44b77e3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants