Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

refactor: add webpack-defaults #70

Closed
wants to merge 2 commits into from
Closed

refactor: add webpack-defaults #70

wants to merge 2 commits into from

Conversation

michael-ciniawsky
Copy link
Member

@michael-ciniawsky michael-ciniawsky commented Apr 9, 2017 •
edited by joshwiens

⚠️ Do not merge ⚠️

  • add webpack-defaults
  • add tests (WIP)
  • add LOADER.md (JSDoc)
  • update README.md

TODO

  • add schema-utils
  • finish tests

Discussion

Is file-loader as a peerDependency correct ?

Closes #69

@michael-ciniawsky michael-ciniawsky self-assigned this Apr 9, 2017
This was referenced Apr 9, 2017
Closed
Closed
Closed
Merged
Closed
Closed
@joshwiens joshwiens mentioned this pull request Apr 12, 2017
Closed
joshwiens
joshwiens reviewed Apr 12, 2017
View reviewed changes
Copy link
Member

@joshwiens joshwiens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand it, file loader is required in most if not all use cases so yes, it should be listed as a peerDep.

We should take the opportunity to tighten the range from * to the current Major at a minimum.

@michael-ciniawsky michael-ciniawsky mentioned this pull request Jun 9, 2017
Closed
@michael-ciniawsky
Copy link
Member Author

Closing in favor of #102

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joshwiens joshwiens joshwiens left review comments

@bebraw bebraw Awaiting requested review from bebraw

Assignees

@michael-ciniawsky michael-ciniawsky

Labels
semver: Major status: Declined type: Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michael-ciniawsky @joshwiens