setTimeout -> setImmediate #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to be sure that bundle-analyzer is not killed if you run webpack through wrappers like grunt-webpack
Closed
|
Thanks! |
|
In v1.5.4 |
eirikurn
pushed a commit
to aranja/webpack-bundle-analyzer
that referenced
this pull request
Feb 7, 2017
It appears to be a common issue that the `webpack --json` output can include non-JSON content with certain plugins or loaders. Trying to extract the JSON output automatically from the mixed input is likely to be tricky, but we can at least provide a clearer diagnosis of the problem. Fixes webpack-contrib#13 Fixes webpack-contrib#19 Fixes webpack-contrib#21 Fixes webpack-contrib#30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you run webpack not directly but through a wrapper (like grunt-webpack) then using
setTimeoutgenerates race conditions: sometimes grunt is killing webpack thinking that everything went good and bundle-analyze is not firing at all.Changing that to
setImmediatefixes the problem and still placing all the logs to the bottom