Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update acorn to version 6 #248

Merged
merged 1 commit into from Feb 25, 2019
Merged

Update acorn to version 6 #248

merged 1 commit into from Feb 25, 2019

Conversation

@realityking
Copy link
Contributor

@realityking realityking commented Feb 4, 2019

Fixes #245

Supporting both acorn 5 and acorn 6 is not feasible because acorn-walk got split into its own module.

@th0r
Copy link
Collaborator

@th0r th0r commented Feb 15, 2019

Won't it break setups with webpack 3?

@domoratskii
Copy link

@domoratskii domoratskii commented Feb 19, 2019

Hi! Are you going to merge ?

@realityking
Copy link
Contributor Author

@realityking realityking commented Feb 25, 2019

@th0r I don't see why it would webpack-bundle-analyzer parses the JS file itself and does not rely on the AST generated by webpack. Bundle analyzer will support more language features than webpack itself but that's a much better situation than the opposite.

@th0r th0r merged commit b04a23c into webpack-contrib:master Feb 25, 2019
2 checks passed
@th0r
Copy link
Collaborator

@th0r th0r commented Feb 25, 2019

@realityking yep, you're right. Merged. Thanks!

@realityking realityking deleted the acorn-6 branch Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants