Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for mjs #252

Merged
merged 6 commits into from Mar 5, 2019
Merged

support for mjs #252

merged 6 commits into from Mar 5, 2019

Conversation

@jlopezxs
Copy link
Contributor

@jlopezxs jlopezxs commented Mar 4, 2019

#229

@jsf-clabot
Copy link

@jsf-clabot jsf-clabot commented Mar 4, 2019

CLA assistant check
All committers have signed the CLA.

@valscion
Copy link
Member

@valscion valscion commented Mar 5, 2019

Please remove yarn.lock. You will also need to sign the CLA

src/analyzer.js Outdated Show resolved Hide resolved
jlopezxs and others added 2 commits Mar 5, 2019
Co-Authored-By: jlopezxs <jlopezxs@gmail.com>
@valscion
Copy link
Member

@valscion valscion commented Mar 5, 2019

Thanks! Looks nice. Do you mind adding a new changelog entry right under the

## UNRELEASED

<!-- Add changelog entries for new changes under this section -->

<!-- comment?

CHANGELOG.md Outdated
<!--
* **Improvement**
* Add support JS modules ([#252](https://github.com/webpack-contrib/webpack-bundle-analyzer/pull/252), [@jlopezxs](https://github.com/jlopezxs)))
-->
Copy link
Member

@valscion valscion Mar 5, 2019

Ah, you don't need to add the new changelog entry in a comment ☺️. Only the "Add changelog entries" line needs to be a comment, new entries can be listed as is.

Also, what do you think if the wording was changed to "Add support for .mjs output files"? I fear that "support for JS modules" would cause people to think that webpack-bundle-analyzer didn't support JS modules as sources before. Because this PR is about supporting .mjs output files, right?

@valscion
Copy link
Member

@valscion valscion commented Mar 5, 2019

Looks good to me 👍. Thanks for contributing!

@valscion valscion merged commit a99fc91 into webpack-contrib:master Mar 5, 2019
2 checks passed
@valscion
Copy link
Member

@valscion valscion commented Apr 6, 2019

This is now released in webpack-bundle-analyzer v3.2.0. Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants