Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved readability: fixed serif font and tooltip opacity #320

Merged
merged 2 commits into from Oct 10, 2019

Conversation

@lorenzos
Copy link
Contributor

@lorenzos lorenzos commented Oct 9, 2019

On my system there's no Verdana font, therefore sidebar and tooltips are displayed with the ugly default serif font. I added an explicit sans-serif fallback for the --main-font CSS variable, to make the system use the non-serif default font, at least.

I also increased the opacity of tooltips to make them more readable against background text.

Here's a before / after:

Istantanea_2019-10-09_17-50-47 Istantanea_2019-10-09_17-50-59

@jsf-clabot
Copy link

@jsf-clabot jsf-clabot commented Oct 9, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@valscion
Copy link
Member

@valscion valscion commented Oct 10, 2019

Thanks, seems like good changes to me! Can you sign the CLA please? Otherwise we are not allowed to merge your PR

@lorenzos
Copy link
Contributor Author

@lorenzos lorenzos commented Oct 10, 2019

Can you sign the CLA please?

I did. If I click the link again (or the "Details" one next to the checks) it says "You have signed the CLA for webpack-contrib/webpack-bundle-analyzer", and it doesn't let me do again, the form at the bottom is disabled.

@valscion valscion closed this Oct 10, 2019
@valscion valscion reopened this Oct 10, 2019
@valscion
Copy link
Member

@valscion valscion commented Oct 10, 2019

Thanks for letting me know — seems like the CLA check had syncing issues. Closing and reopening the PR did the trick ☺️

@th0r
th0r approved these changes Oct 10, 2019
@th0r th0r merged commit f49796f into webpack-contrib:master Oct 10, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@valscion
Copy link
Member

@valscion valscion commented Oct 16, 2019

Released in v3.6.0 ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.