Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persisted "Show content of concatenated modules" with localStorage #322

Merged
merged 6 commits into from Apr 13, 2020

Conversation

@lorenzos
Copy link
Contributor

@lorenzos lorenzos commented Oct 10, 2019

As discussed in #321.

To my surprise, this works also when { analyzerMode: 'static' }: I didn't know browsers save localStorage for local files too.

@valscion
Copy link
Member

@valscion valscion commented Oct 11, 2019

Thanks! We should probably guard for localStorage methods raising errors, as there are plenty of situations where they could fail and the UI should work anyway

@th0r
Copy link
Collaborator

@th0r th0r commented Oct 11, 2019

Yep, we should create a small module that will wrap all the localStorage methods with try {} catch.

@lorenzos
Copy link
Contributor Author

@lorenzos lorenzos commented Oct 11, 2019

Done in latest commit. Instead of creating a new module, I used utils.js.

client/utils.js Outdated Show resolved Hide resolved
client/utils.js Outdated Show resolved Hide resolved
client/utils.js Outdated Show resolved Hide resolved
client/utils.js Outdated Show resolved Hide resolved
client/utils.js Outdated Show resolved Hide resolved
client/utils.js Outdated Show resolved Hide resolved
client/utils.js Outdated Show resolved Hide resolved
client/utils.js Outdated Show resolved Hide resolved
client/store.js Outdated Show resolved Hide resolved
client/components/ModulesTreemap.jsx Outdated Show resolved Hide resolved
lorenzos and others added 2 commits Oct 11, 2019
Co-Authored-By: Yuriy Grunin <grunin.ya@ya.ru>
@lorenzos
Copy link
Contributor Author

@lorenzos lorenzos commented Oct 14, 2019

Should be ok now @ 9823e7c

@valscion
Copy link
Member

@valscion valscion commented Oct 17, 2019

Looks good to me, what do you think @th0r?

It would be nice to have a changelog entry for this, similar to what we have for other things. This would be an "Improvement" change

@valscion valscion requested a review from th0r Oct 17, 2019
@lorenzos
Copy link
Contributor Author

@lorenzos lorenzos commented Apr 11, 2020

News on this?

@th0r
Copy link
Collaborator

@th0r th0r commented Apr 13, 2020

It would be nice to have a changelog entry for this, similar to what we have for other things. This would be an "Improvement" change

@lorenzos could you add a note to CHANGELOG.md under UNRELEASED section please?

@lorenzos
Copy link
Contributor Author

@lorenzos lorenzos commented Apr 13, 2020

@lorenzos could you add a note to CHANGELOG.md under UNRELEASED section please?

Done. Sorry, I didn't get that the request was addressed to me back then :)

@th0r
th0r approved these changes Apr 13, 2020
@th0r th0r merged commit 29beb70 into webpack-contrib:master Apr 13, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@th0r
Copy link
Collaborator

@th0r th0r commented Apr 13, 2020

Thanks, merged!

@valscion
Copy link
Member

@valscion valscion commented Apr 14, 2020

This has been released in v3.7.0 ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.