Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for node bundle #345

Merged
merged 2 commits into from May 6, 2020
Merged

add support for node bundle #345

merged 2 commits into from May 6, 2020

Conversation

@Spikef
Copy link
Contributor

@Spikef Spikef commented Apr 24, 2020

when webpack config target=node, the modules are store at exports.modules.

https://github.com/webpack/webpack/blob/157c457241bf46b1cb31dbb17e806702eb4a0ec5/lib/node/NodeTemplatePlugin.js#L39

test/bundles/validNodeBundleWithModulesAsArray.js Outdated Show resolved Hide resolved
src/parseUtils.js Outdated Show resolved Hide resolved
src/parseUtils.js Outdated Show resolved Hide resolved
@th0r
th0r approved these changes May 6, 2020
@th0r th0r merged commit 757c12e into webpack-contrib:master May 6, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@th0r
Copy link
Collaborator

@th0r th0r commented May 6, 2020

Merged, thanks!

@valscion
Copy link
Member

@valscion valscion commented May 19, 2020

This has been released in v3.8.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.