Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed left side check to support custom global object which can be any string #352

Conversation

@Gongreg
Copy link
Contributor

@Gongreg Gongreg commented May 19, 2020

Issue: #350 .

Removed left hand checks, since they seem redundant. All the tests are passing. Added test case for a custom global object.

Closes #350

@valscion
Copy link
Member

@valscion valscion commented May 19, 2020

Thanks! Can you add a changelog entry for this to CHANGELOG.md? This seems like either an improvement or a bug fix, given that we now support parsing more bundles than before.

Gongreg added 2 commits May 19, 2020
@Gongreg
Copy link
Contributor Author

@Gongreg Gongreg commented May 19, 2020

done

@valscion
Copy link
Member

@valscion valscion commented May 19, 2020

Thanks! This looks good to me. Now that I can see the full conditional, it's unlikely that this would suddenly start parsing "successfully" some file in the bundle output directory which would not be a valid webpack bundle.

@valscion valscion merged commit 5cf45eb into webpack-contrib:master May 19, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@Gongreg
Copy link
Contributor Author

@Gongreg Gongreg commented May 19, 2020

Yes, the right hand side check seems quite foul proof, on top of that this check is checking for .push.

@valscion
Copy link
Member

@valscion valscion commented May 19, 2020

This has been released in v3.8.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.