Removed left side check to support custom global object which can be any string #352
Conversation
|
Thanks! Can you add a changelog entry for this to |
|
done |
|
Thanks! This looks good to me. Now that I can see the full conditional, it's unlikely that this would suddenly start parsing "successfully" some file in the bundle output directory which would not be a valid webpack bundle. |
|
Yes, the right hand side check seems quite foul proof, on top of that this check is checking for |
|
This has been released in v3.8.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Issue: #350 .
Removed left hand checks, since they seem redundant. All the tests are passing. Added test case for a custom global object.
Closes #350