Support Webpack 5 #389
Merged
Support Webpack 5 #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
th0r
commented
Nov 3, 2020
•
th0r
commented
- Remove support for Node.js 6 and 8 (set minimum required version to 10.13.0)
- Update dependencies
- Support multiple Webpack versions in tests
- Fix webpack5: Unable to view parsed and gzip stats for the main entrypoint #387
- Fix webpack 5: Detailed bundle structure is gone #388
- Bump major version
- Update changelog
- Fix tests to support Webpack 5
|
@valscion do you want to take a look? |
|
Yup, I'll check this out :) |
valscion
requested changes
Nov 6, 2020
There was a problem hiding this comment.
Nice, I'm thrilled with having the possibility of creating tests for multiple different webpack versions!
At first I got mysterious errors for various tests and was super confused — then I cloned the entire repository from a clean slate and discovered I had forgot to run npm run build before running tests 😅. After running that, all tests passed for me locally, too 🎉
My comments are only minor in nature. I didn't go through all of the changes you did to parsing bundles logic as I trust the tests to be good enough to ensure that the logic is correct
valscion
approved these changes
Nov 6, 2020
This was referenced Nov 6, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.