Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace mkdirp with builtin recursive flag #391

Merged
merged 4 commits into from Nov 8, 2020

Conversation

TrySound
Copy link
Contributor

@TrySound TrySound commented Nov 6, 2020

In node 10.12 mkdir got new recursive flag which provides the same
functionality as mkdirp.

See here https://nodejs.org/api/fs.html#fs_fs_mkdir_path_options_callback

Also node 10 got builtin promisified fs utilities.

See here https://nodejs.org/api/fs.html#fs_fs_promises_api

In node 10.12 mkdir got new recursive flag which provides the same
functionality as mkdirp.

See here https://nodejs.org/api/fs.html#fs_fs_mkdir_path_options_callback

Also node 10 got builtin promisified `fs` utilities.

See here https://nodejs.org/api/fs.html#fs_fs_promises_api
src/BundleAnalyzerPlugin.js Outdated Show resolved Hide resolved
src/viewer.js Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
th0r
th0r approved these changes Nov 6, 2020
@th0r
Copy link
Collaborator

@th0r th0r commented Nov 7, 2020

licence/cla check is stuck for some reason. @valscion do you know how to fix it?

@th0r th0r merged commit d093666 into webpack-contrib:master Nov 8, 2020
2 checks passed
@th0r
Copy link
Collaborator

@th0r th0r commented Nov 8, 2020

Thanks!

@valscion
Copy link
Member

@valscion valscion commented Nov 9, 2020

licence/cla check is stuck for some reason. @valscion do you know how to fix it?

Closing and reopening the pull request triggers a new licence/cla check in case the service was down for some reason in the past — that's how I've dealt with these situations before 😅

@TrySound
Copy link
Contributor Author

@TrySound TrySound commented Nov 9, 2020

I just do empty commits in such cases

@valscion
Copy link
Member

@valscion valscion commented Nov 30, 2020

Released in v4.2.0 ☺️. Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants