Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move filesize to dev dependencies #401

Merged
merged 1 commit into from Dec 2, 2020

Conversation

realityking
Copy link
Contributor

@realityking realityking commented Dec 1, 2020

It's only used in the client

It's only used in the client
@realityking realityking changed the title Move filesize to dev depnendencies Move filesize to dev dependencies Dec 1, 2020
@TrySound
Copy link
Contributor

@TrySound TrySound commented Dec 1, 2020

Is client bundled before publishing?

@@ -37,7 +37,6 @@
"acorn-walk": "^8.0.0",
"chalk": "^4.1.0",
Copy link
Member

@alexander-akait alexander-akait Dec 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be replaced by colorette (light, fast and with simple API), already used in webpack-cli@4, so for developers which use webpack-cli and webpack-bundle-analyzer we will have less deps

Copy link
Contributor Author

@realityking realityking Dec 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point but something for a different PR :)

Copy link
Member

@valscion valscion left a comment

Cool 👍 Just checked that mobx is also only in devDependencies so client-only packages are OK to be specified only in devDependencies 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants