Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Travis with GitHub actions as CI #402

Merged
merged 6 commits into from Dec 3, 2020
Merged

Replace Travis with GitHub actions as CI #402

merged 6 commits into from Dec 3, 2020

Conversation

valscion
Copy link
Member

@valscion valscion commented Dec 2, 2020

Resolves #400

@valscion valscion requested a review from th0r Dec 2, 2020
@valscion
Copy link
Member Author

@valscion valscion commented Dec 2, 2020

I disabled the continuous-integration/travis-ci branch protection for now so that this PR is not blocked on advancing. If @th0r you feel like this is good to go, I can add branch protections for the GitHub actions if necessary.

@valscion valscion changed the title Setup GitHub actions to run tests and lint Replace Travis with GitHub actions as CI Dec 2, 2020
@th0r
Copy link
Collaborator

@th0r th0r commented Dec 2, 2020

I wonder is it possible to add Node.js prefix to version numbers as now it's a bit not obvious what do these numbers mean?

image

@valscion
Copy link
Member Author

@valscion valscion commented Dec 2, 2020

I don't know — I can check if that's possible when I have the time ☺️

@valscion
Copy link
Member Author

@valscion valscion commented Dec 3, 2020

It now looks like so:

Replace_Travis_with_GitHub_actions_as_CI_by_valscion_·_Pull_Request__402_·_webpack-contrib_webpack-bundle-analyzer

It seems quite simple to change the name to whatever we want as can be seen by fdb5a0e — feel free to make a direct code suggestion to this PR if you have a better wording in mind ☺️

.github/workflows/main.yml Outdated Show resolved Hide resolved
Co-authored-by: Yuriy Grunin <grunin.ya@ya.ru>
th0r
th0r approved these changes Dec 3, 2020
Copy link
Collaborator

@th0r th0r left a comment

Great, thanks!

@valscion valscion merged commit 2d12514 into master Dec 3, 2020
5 checks passed
@valscion valscion deleted the github-actions branch Dec 3, 2020
@valscion
Copy link
Member Author

@valscion valscion commented Dec 3, 2020

I can add branch protections for the GitHub actions if necessary.

Do we need the branch protections? I'm not sure if they're necessary — a red CI should be enough for us to avoid merging pull requests.

The CLA-check of course stays as a required status check.

@th0r
Copy link
Collaborator

@th0r th0r commented Dec 3, 2020

Do we need the branch protections?

I don't even know what is that =)

@valscion
Copy link
Member Author

@valscion valscion commented Dec 3, 2020

Ah, it's this one:

feat__Render_Selected_Module_Size_Total_by_vwb_·_Pull_Request__346_·_webpack-contrib_webpack-bundle-analyzer

So one can't merge a pull request (unless they're an admin and admin overrule is allowed) if a required status check is not successful.

We could configure some or all of the GitHub Actions status checks to be required to be successful to allow merging via https://github.com/webpack-contrib/webpack-bundle-analyzer/settings/branches, from here:

Branch_protection_rule

@th0r
Copy link
Collaborator

@th0r th0r commented Dec 3, 2020

Ah, ok, thanks for the explanation. I don't think we need it.

@valscion
Copy link
Member Author

@valscion valscion commented Dec 3, 2020

Yeah I think the same, let's keep it as it is now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants