Resolve path to "webpack-hot-client/client" (support for monorepos)

[frenzzy]

• This is a bugfix
• This is a new feature
• This is a code refactor
• This is a test update
• This is a typo fix
• This is a metadata update

For Bugs and Features; did you add new tests?

Should I?

Motivation / Use-Case

Fixes an error which appears if module installed in the separate node_modules directory:

ERROR in multi webpack-hot-client/client?client ./src/app.js
Module not found: Error: Can't resolve 'webpack-hot-client/client?client' in '/my-create-react-app'

Breaking Changes

Additional Info

[jsf-clabot]

All committers have signed the CLA.

[codecov]

Codecov Report

Merging #62 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
+ Coverage   99.32%   99.32%   +<.01%     
==========================================
  Files           3        3              
  Lines         148      149       +1     
==========================================
+ Hits          147      148       +1     
  Misses          1        1

Impacted Files	Coverage Δ
lib/util.js	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 276d950...828b3fd. Read the comment docs.

[shellscape]

Thanks for the PR 🍺

This is a tough one. There should never be more than one version of webpack-hot-client installed so this should succeed no matter what. Your monorepo setup should account for this, in theory, and add the proper symlinks to be able to resolve dependencies.

I'm not convinced this change is needed as yet, but I'm open to further discussion.

For Bugs and Features; did you add new tests?
Should I?

According to the PR template, yes:

<!-- Please note that we won't approve your changes if you don't add tests. -->

[shellscape]

Thanks again for your work and opening a PR. Going to pass on this one, however. In monorepos webpack.config.js can contain a resolve-alias that should cover this case, without having to muck with absolute paths in the codebase. e.g.

  resolve: {
    alias: {
      'webpack-hot-client/client': path.resolve(...),
    },
  },

This approach also allows a user to use require.resolve or enhanced-resolve as alternatives, for example. It's far more flexible than the proposed change in the PR.