Replace 'compile' with 'invalid' hook. #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The logic should be duplicated in the lower section to maintain compatibility with webpack v3. It might be best to switch to the |
|
The author recommends the iterating way here, but yeah, using invalid hook seems to be the easiest solution actually. Though, I don’t know if there’s a difference between compile and invalid hooks. :confuse: I’ll make the change later and notify you when I’m done! |
|
I've revised the code. PTAL, thanks! |
qazbnm456
changed the title
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #260.
As suggested webpack/webpack#6633 (comment), we rather iterate each compiler and register the 'compile' hook when getting a MultiCompiler instance than register the 'invalid' hook.