New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve logic for handling multicomplier stats result to accomodate webpack5 #429
feat: improve logic for handling multicomplier stats result to accomodate webpack5 #429
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add tests case and accept CLA? thank you
@@ -46,4 +46,4 @@ jobs: | |||
working_directory: /mnt/ramdisk | |||
steps: | |||
- setup | |||
- run: npm test | |||
- run: NODE_OPTIONS=--openssl-legacy-provider npm test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexander-akait I added tests cases and accepted the CLA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glenjamin Hellom can I take care about webpack-hot-middleware
, becauwe we have a lot of PRs and issues, I want to start to fix them and in future union webpack-dev-server/webpack-dev-middleware and webpack-hot-middleware in the one repo, and reuse the same code for better maintanance
Yep, please go ahead - I've not been actively planning anything |
@eokoneyo Thank you |
This PR contains a:
Motivation / Use-Case
This PR aims to address an issue I think is related to #390,
Details of my system setup;
I had a similar issue on further investigation, I realized that the problem happens because the shape of stats object returned in Webpack 5 differs from that of Webpack 4. See here.
This PR checks the returned stats object for the
stats
property on the returnedstatsResult
which also present on multicomplier stats results generated from Webpack, the returned stats is handled as such if this is the case, from there on everything works like it should.Breaking Changes
Additional Info