feat: add `publicPath` support (`options.publicPath`) #31

DullReferenceException · 2016-09-30T19:38:06Z

Our web app hosts static assets on a CDN, making the loading of web worker scripts difficult due to cross-origin policies. The inline option works for most browsers, but we started experiencing some difficulties with Safari due to its handling of Unicode in blobs being inconsistent with other browsers. This proxy option lets the worker load from a same-origin URL; in our case, we have some middleware in which we proxy the request to the webpack dev server (for local development) or serve up a local file.

Noteable Changes

Added the ability to use a proxy URL when loading workers as a way to work around cross-origin policy issues.

ℹ️ edited by @michael-ciniawsky (Formatting)

michael-ciniawsky

Needs Rebase && Tests

michael-ciniawsky · 2017-07-04T14:00:37Z

.gitignore

+node_modules
+.idea


Please revert this

michael-ciniawsky · 2017-10-12T14:02:37Z

Can you rebase please ? So I can finally review this ? :)

jsf-clabot · 2017-10-12T15:56:52Z

All committers have signed the CLA.

DullReferenceException · 2017-10-12T16:00:38Z

@michael-ciniawsky: rebased and added a unit test now that unit tests are supported.

michael-ciniawsky

Maybe better to name the option publicPath instead ?

cc @TrySound

michael-ciniawsky · 2017-10-12T16:12:49Z

index.js

@@ -9,7 +9,8 @@ const SingleEntryPlugin = require('webpack/lib/SingleEntryPlugin');
 const schema = require('./options.json');

 const getWorker = (file, content, options) => {
-  const workerPublicPath = `__webpack_public_path__ + ${JSON.stringify(file)}`;
+  const basePath = options.proxy ? JSON.stringify(options.proxy) : '__webpack_public_path__';


basePath => publicPath or inline it into the template literal

michael-ciniawsky

@DullReferenceException Thx

michael-ciniawsky · 2017-10-12T16:45:05Z

@DullReferenceException Could you just add /* eslint-disable comma-dangle, arrow-body-style */ at the top in test/index.js please so CI passes?

michael-ciniawsky · 2017-10-12T16:47:27Z

or fix them all good 😛

michael-ciniawsky · 2017-10-14T11:59:44Z

@DullReferenceException Please one last rebase sry 😛

@TrySound @d3viant0ne @evilebottnawi Any objections against this ? Please review when time 🙃

joshwiens · 2017-10-15T02:54:03Z

README.md

@@ -151,3 +170,8 @@ const worker: Worker = new MyWorker();

 [test]: http://img.shields.io/travis/webpack-contrib/worker-loader.svg
 [test-url]: https://travis-ci.org/webpack-contrib/worker-loader
+
+
+## License


This shouldn't be here but should go away on the last rebase

joshwiens · 2017-10-15T02:58:18Z

README.md

@@ -91,6 +91,25 @@ self.postMessage({foo: 'foo'})
 self.addEventListener('message', (event) => { console.log(event); });
 ```

+
+## Cross-origin policy workarounds
+


Can we describe the feature to be less use case specific?

Feel free to add the worker cross-origin policy as an example underneath.

Add publicPath to table that describes the api

Add ## Public Path docs below the existing sections describing the api options

Add generic example

Add note about workaround for cross-origin specific usecase.

@michael-ciniawsky Other than the documentation, it looks fine pending a thumbs up from @TrySound

👍 I've rebased & updated the documents.

Added the ability to use a different public path when loading workers as a way to work around cross-origin policy issues.

TrySound

Looks good

michael-ciniawsky

@DullReferenceException Thx

…b#31)

michael-ciniawsky changed the title ~~Proxy parameter~~ feat: add proxy support (options.proxy) Jul 4, 2017

michael-ciniawsky added flag: Needs Tests priority: 4 (important) pr_action: Review semver: Minor status: Pending type: Feature pr_action: Rebase and removed pr_action: Review labels Jul 4, 2017

michael-ciniawsky added this to the 0.9.0 milestone Jul 4, 2017

michael-ciniawsky requested review from alexander-akait, michael-ciniawsky, TrySound and joshwiens July 4, 2017 14:00

michael-ciniawsky suggested changes Jul 4, 2017

View reviewed changes

.gitignore Outdated

node_modules

.idea

Copy link

Member

michael-ciniawsky Jul 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this

DullReferenceException force-pushed the proxy-param branch from ee1a2c4 to 4993636 Compare October 12, 2017 15:56

DullReferenceException force-pushed the proxy-param branch from 4993636 to 7e58614 Compare October 12, 2017 16:04

michael-ciniawsky suggested changes Oct 12, 2017

View reviewed changes

michael-ciniawsky added pr_action: Review and removed flag: Needs Tests pr_action: Rebase labels Oct 12, 2017

michael-ciniawsky changed the title ~~feat: add proxy support (options.proxy)~~ feat: add custom publicPath support (options.publicPath) Oct 12, 2017

michael-ciniawsky approved these changes Oct 12, 2017

View reviewed changes

DullReferenceException force-pushed the proxy-param branch from 54c0d89 to 7dc6d39 Compare October 12, 2017 16:50

michael-ciniawsky changed the title ~~feat: add custom publicPath support (options.publicPath)~~ feat: add publicPath support (options.publicPath) Oct 14, 2017

michael-ciniawsky added pr_action: Rebase and removed pr_action: Review labels Oct 14, 2017

joshwiens approved these changes Oct 15, 2017

View reviewed changes

joshwiens reviewed Oct 15, 2017

View reviewed changes

joshwiens suggested changes Oct 15, 2017

View reviewed changes

DullReferenceException force-pushed the proxy-param branch from 7dc6d39 to 3a481c3 Compare October 16, 2017 16:05

publicPath option

84f555d

Added the ability to use a different public path when loading workers as a way to work around cross-origin policy issues.

DullReferenceException force-pushed the proxy-param branch from 3a481c3 to 84f555d Compare October 16, 2017 16:28

TrySound approved these changes Oct 16, 2017

View reviewed changes

alexander-akait approved these changes Oct 17, 2017

View reviewed changes

michael-ciniawsky approved these changes Oct 19, 2017

View reviewed changes

michael-ciniawsky added status: Approved and removed priority: 4 (important) pr_action: Rebase status: Pending labels Oct 19, 2017

michael-ciniawsky merged commit 96c6144 into webpack-contrib:master Oct 19, 2017

michael-ciniawsky mentioned this pull request Oct 20, 2017

change worker file path inline #102

Closed

Swizec mentioned this pull request Oct 24, 2017

Weird install issues with latest 3 commits on master #104

Closed

michael-ciniawsky removed this from the 1.1.0 milestone Oct 24, 2017

TheLD6978 pushed a commit to TheLD6978/worker-loader that referenced this pull request Apr 16, 2021

feat: add publicPath support (options.publicPath) (webpack-contri…

2cb6a11

…b#31)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add `publicPath` support (`options.publicPath`) #31

feat: add `publicPath` support (`options.publicPath`) #31

DullReferenceException commented Sep 30, 2016 •

edited by michael-ciniawsky

Loading

michael-ciniawsky left a comment

michael-ciniawsky Jul 4, 2017

michael-ciniawsky commented Oct 12, 2017

jsf-clabot commented Oct 12, 2017 •

edited

Loading

DullReferenceException commented Oct 12, 2017

michael-ciniawsky left a comment

michael-ciniawsky Oct 12, 2017 •

edited

Loading

michael-ciniawsky left a comment

michael-ciniawsky commented Oct 12, 2017 •

edited

Loading

michael-ciniawsky commented Oct 12, 2017

michael-ciniawsky commented Oct 14, 2017

joshwiens Oct 15, 2017

joshwiens Oct 15, 2017

joshwiens Oct 15, 2017

DullReferenceException Oct 16, 2017

TrySound left a comment

michael-ciniawsky left a comment

feat: add publicPath support (options.publicPath) #31

feat: add publicPath support (options.publicPath) #31

Conversation

DullReferenceException commented Sep 30, 2016 • edited by michael-ciniawsky Loading

Noteable Changes

michael-ciniawsky left a comment

Choose a reason for hiding this comment

michael-ciniawsky Jul 4, 2017

Choose a reason for hiding this comment

michael-ciniawsky commented Oct 12, 2017

jsf-clabot commented Oct 12, 2017 • edited Loading

DullReferenceException commented Oct 12, 2017

michael-ciniawsky left a comment

Choose a reason for hiding this comment

michael-ciniawsky Oct 12, 2017 • edited Loading

Choose a reason for hiding this comment

michael-ciniawsky left a comment

Choose a reason for hiding this comment

michael-ciniawsky commented Oct 12, 2017 • edited Loading

michael-ciniawsky commented Oct 12, 2017

michael-ciniawsky commented Oct 14, 2017

joshwiens Oct 15, 2017

Choose a reason for hiding this comment

joshwiens Oct 15, 2017

Choose a reason for hiding this comment

joshwiens Oct 15, 2017

Choose a reason for hiding this comment

DullReferenceException Oct 16, 2017

Choose a reason for hiding this comment

TrySound left a comment

Choose a reason for hiding this comment

michael-ciniawsky left a comment

Choose a reason for hiding this comment

feat: add `publicPath` support (`options.publicPath`) #31

feat: add `publicPath` support (`options.publicPath`) #31

DullReferenceException commented Sep 30, 2016 •

edited by michael-ciniawsky

Loading

jsf-clabot commented Oct 12, 2017 •

edited

Loading

michael-ciniawsky Oct 12, 2017 •

edited

Loading

michael-ciniawsky commented Oct 12, 2017 •

edited

Loading