chore: Allow Webpack v3.x as a peerDependency #85
Conversation
|
|
michael-ciniawsky
changed the title
webpack v3.0.0 (peerDependencies)
package.json
Outdated
| @@ -28,7 +28,7 @@ | |||
| } | |||
| }, | |||
| "peerDependencies": { | |||
| "webpack": ">=0.9 <2 || ^2.1.0-beta || ^2.2.0" | |||
| "webpack": ">=0.9 <2 || ^2.1.0-beta || >=2.2.0 <4" | |||
There was a problem hiding this comment.
^1.0.0 || ^2.0.0 || ^3.0.0
There was a problem hiding this comment.
That would include 2.0.x again and disallow 0.9, which I'd consider a breaking change (semver major).
There was a problem hiding this comment.
There was never a 2.0.x the first release without -beta was v2.2.0 to my knowledge. Yep for the >= 0.9 if really needed just >= 0.9 || ^1.0.0 || ^2.0.0 || ^3.0.0 then imho
There was a problem hiding this comment.
or >= 0.9 < 4 or even just < 4 ?
There was a problem hiding this comment.
@danez - Yes, we can land a quick patch.
yes, please! adding this in a patch release means we won't have to bug libs that depend on |
There was a problem hiding this comment.
@fb55 - Set the peerDependencies to "webpack": ">=0.9 || ^2.0.0 || ^3.0.0"
For reference ...
- We can't drop the
>=0.9without asemver:Majorregardless of the fact it's no longer supported, this will be taken care of with refactor: applywebpack-defaults#81. - Beta / rc versions are no longer supported once the associated major version is published on the
latestdist-tag and shouldn't be in the peerDependency range.
joshwiens
changed the title
webpack v3.0.0 (peerDependencies)
|
@d3viant0ne any plans to publish this version on NPM? |
|
@d3viant0ne Friendly bump as you took care of webpack-contrib/coffee-loader#39 You merged Webpack 3 support but did not release on NPM, preventing users to upgrade to Webpack 3 (corresponding issue: #75) Thanks! 🍰 |
|
yes @d3viant0ne please create a release :) |
|
any update on releasing this? We're currently blocked on shrinkwrapping a release due to npm ...interesting... behavior wrt peerDependencies and shrinkwrap, and can't update npm until after this release. Bit of a catch-22. |
No description provided.