Skip to content
This repository has been archived by the owner on Aug 8, 2019. It is now read-only.

Update docs for NoErrorsPlugin deprecation and rename to NoEmitOnErrorsPlugin #96

Open
zachlysobey opened this issue Feb 6, 2017 · 7 comments

Comments

@zachlysobey
Copy link

The NoErrorsPlugin was deprecated in webpack PR#3570 and renamed to NoEmitOnErrorsPlugin

The docs here should probably be updated to reflect that.

@BrainCrumbz
Copy link

Does this still apply, now that Doc github repo moved? There seems to be no reference to none of the two in https://webpack.js.org/configuration/plugins/, nor in https://github.com/webpack/webpack.js.org/tree/master/content/plugins

@zachlysobey
Copy link
Author

@BrainCrumbz I'm not really clear on where any docs have moved, or what the plan is moving forward,... but the docs I linked to still exist, and are still incomplete/misleading. If these are not the current docs, then I would guess that they should be removed, and replaced with a redirect or a link to the current documentation.

@BrainCrumbz
Copy link

BrainCrumbz commented Mar 1, 2017

Did you check this project home? The big prints says that they moved to https://github.com/webpack/webpack.js.org, that changes here should be done on local wiki, but then again it says to submit issues/PRs at the new repo.

So I guess a good move could be to either apply the change directly to wiki plugin list or move this issue to the new repo.

Just sayin'...

@tiendq
Copy link

tiendq commented Apr 21, 2017

I also used NoErrorsPlugin in an old project, just check plugins page and still don't see NoEmitOnErrorsPlugin there 👎

@jwineman
Copy link

jwineman commented Mar 6, 2018

I see noEmitOnErrorsPlugin here:
https://webpack.js.org/plugins/no-emit-on-errors-plugin/

@mernstackman
Copy link

I see it on VSCode is already deprecated too and there is suggestion to use config.optimization.noEmitOnErrors

@devinrhode2
Copy link

devinrhode2 commented Mar 5, 2019

So I tried optimization.noEmitOnErrors, but optimization is not a valid configuration key for webpack THREE - so I renamed the plugin from:

    plugins: [
        new webpack.NoErrorsPlugin(),

to:

    plugins: [
        new webpack.NoEmitOnErrorsPlugin(),

The deprecation warning is gone, so I guess handling this for webpack3 is as easy as just renaming the plugin.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants