This repository has been archived by the owner on Sep 15, 2023. It is now read-only.
Upgrade to webpack 2 #411
Closed
Upgrade to webpack 2 #411
+7,869
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typo: devlopment --> development
typo: webpackMutiConfig --> webpackMultiConfig
Fixes vigetlabs#251 Only reload once at the end of the stream to keep browser from reloading too early
typo: minfified --> minified
Fix Browsersync html task reload issue
Shopify Watch/Deploy Extra
Resolves issue with Node ^6.5 and the javascript bundle
Fix vigetlabs#324 update babel-core to 6.10.4
…onfig Fixed the config string for autoprefixer to use "last 3 versions" (plural).
If you’re mounting public as a volume, you can’t rm it from inside the Docker container.
Fixed typo in images.js
|
I accidentally used the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I upgraded the repo to use the latest available version of Webpack (2.3.3).
Webpack 2 has introduced some breaking changes, which are pretty well documented. The
blendidconfig seems pretty straightforward, so the update should be easy enough to pull in without much hassle.The relevant updates are:
module.resolveis nowmodule.rulessee the migration guideDedupePluginwas removed from webpack see the migration guideNoErrorsPluginhas been renamed toNoOmitErrorsPlugin. Hasn't been documented yetAfter the upgrade I tested the project with
gulpandgulp production, which both seem to work fine.There is a warning thrown by
loaderUtils.parseQuery()receiving a non-string value, which seems to be Webpack's way of asking module loader devs to do something about it, but it is unclear what's really going on (webpack/loader-utils#56).