-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatibility with node fs api. #89
Comments
What version of node did you see this? |
@TheLarkInn i see function as in |
@TheLarkInn I ran into this as well. (For reference, the error I was seeing is the same as this one in CopyWebpackPlugin: webpack-contrib/copy-webpack-plugin#217) The incompatibility is in this method call (and others like it) https://github.com/webpack/enhanced-resolve/blob/master/lib/CachedInputFileSystem.js#L238 The method signature here is https://nodejs.org/dist/latest-v8.x/docs/api/fs.html#fs_fs_readfile_path_options_callback So if you're doing something like
|
Hitting this as well in the context of writing a loader for Webpack. Really annoying and makes it awfully tempting to sidestep the formally correct |
Fixed before, improved here #254 |
I'm not sure this is bugs or expected behavior.
Example:
fileSystem.readFileSync(filename, "utf8")
, not respectutf8
and always returnBuffer
.The text was updated successfully, but these errors were encountered: