Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not cache results for non-string names #100

Merged
merged 1 commit into from
Jul 24, 2017
Merged

Conversation

sokra
Copy link
Member

@sokra sokra commented Jul 24, 2017

fixes #99

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@sokra sokra merged commit 49c1689 into master Jul 24, 2017
@sokra sokra deleted the bugfix/cache-undefined branch July 24, 2017 12:34
@codecov
Copy link

codecov bot commented Jul 24, 2017

Codecov Report

Merging #100 into master will increase coverage by 0.09%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
+ Coverage   94.29%   94.38%   +0.09%     
==========================================
  Files          37       37              
  Lines        1421     1426       +5     
  Branches      310      312       +2     
==========================================
+ Hits         1340     1346       +6     
+ Misses         81       80       -1
Impacted Files Coverage Δ
lib/CachedInputFileSystem.js 93.98% <80%> (+0.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cce0a4...5ae4e83. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants